Commit 6987ee45 authored by Ng Zhi An's avatar Ng Zhi An Committed by Commit Bot

[liftoff] Fix check for offset before moving stack value

With https://crrev.com/c/1925524 we are moving elements on the stack by
their offset, but this transfer recipe is still checking the indices of
src and dst, which is incorrect.

Bug: chromium:1027410
Change-Id: Id7c7523c097bd06f3d107cb4d9de1052fc082105
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930606Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65129}
parent ca16eb1d
......@@ -90,7 +90,7 @@ class StackTransferRecipe {
case VarState::kStack:
switch (src.loc()) {
case VarState::kStack:
if (src_index == dst_index) break;
if (src.offset() == dst.offset()) break;
asm_->MoveStackValue(dst.offset(), src.offset(), src.type());
break;
case VarState::kRegister:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment