Commit 6927e976 authored by Liu Yu's avatar Liu Yu Committed by Commit Bot

[mips64] Skip some tests about CheckedFloat64ToInt64 like arm64

Port: b4e2a1e3

Change-Id: I875a33fba10bd59942392c38500c2b80515aa9cf
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2528897
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Auto-Submit: Liu yu <liuyu@loongson.cn>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71139}
parent 7c496213
......@@ -28285,7 +28285,13 @@ TEST(FastApiCalls) {
CallAndCheck<uint64_t>(0, Behavior::kNoException,
expected_path_for_64bit_test, v8_num(-0.0));
#ifndef V8_TARGET_ARCH_ARM64
#if defined(V8_TARGET_ARCH_ARM64) || defined(V8_TARGET_ARCH_MIPS64)
// TODO(v8:11121): Currently the tests below are executed for non-arm64
// and non-mips64 because they fall down the fast path due to incorrect
// behaviour of CheckedFloat64ToInt64 on arm64 and mips64 (see the
// linked issue for details). Eventually we want to remove the conditional
// compilation and ensure consistent behaviour on all platforms.
#else
// TODO(mslekova): We deopt for unsafe integers, but ultimately we want to
// stay on the fast path.
CallAndCheck<int64_t>(std::numeric_limits<int64_t>::min(),
......@@ -28304,13 +28310,7 @@ TEST(FastApiCalls) {
CallAndCheck<uint64_t>(1ull << 63, Behavior::kNoException,
ApiCheckerResult::kSlowCalled,
v8_num(static_cast<double>(1ull << 63)));
#else
// TODO(v8:11121): Currently the tests above are executed for non-arm64
// because they fall down the fast path due to incorrect behaviour of
// CheckedFloat64ToInt64 on arm64 (see the linked issue for details).
// Eventually we want to remove the conditional compilation and ensure
// consistent behaviour on all platforms.
#endif // V8_TARGET_ARCH_ARM64
#endif // V8_TARGET_ARCH_ARM64 || V8_TARGET_ARCH_MIPS64
// Corner cases - float and double
#ifdef V8_ENABLE_FP_PARAMS_IN_C_LINKAGE
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment