Commit 68de2017 authored by Samuel Groß's avatar Samuel Groß Committed by V8 LUCI CQ

[sandbox] Skip mkgrokdump test in non-sandbox mode

When the sandbox is disabled, object layouts are now different as
ExternalPointerSlots are then 64-bit (raw pointers) instead of 32-bit
(ExternalPointerHandles).

Bug: v8:10391
Change-Id: Ia03d1ae9300fad96e40b77f0ed9544a1a118b74a
Cq-Include-Trybots: luci.v8.try.triggered:v8_linux64_no_sandbox_dbg_ng_triggered
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3884075Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Auto-Submit: Samuel Groß <saelo@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Samuel Groß <saelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83089}
parent 95b02431
......@@ -5,8 +5,8 @@
[
# Only test for default mode x64.
['variant != default or arch != x64 or lite_mode or not pointer_compression', {
['variant != default or arch != x64 or lite_mode or not pointer_compression or not sandbox', {
'*': [SKIP],
}], # variant != default or arch != x64 or lite_mode
}], # variant != default or arch != x64 or lite_mode or not pointer_compression or not sandbox
]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment