Commit 687795e3 authored by Marja Hölttä's avatar Marja Hölttä Committed by Commit Bot

[iwyu] Fixes related to src/machine-type.h

Restores some sensemaking properties, such as making src/machine-type.h (lower
level header) independent of src/zone/zone.h (higher level header).

BUG=v8:7490

Change-Id: Ibc6e5c7a75e4aaf917d086cf70267abc7ee9a9b0
Reviewed-on: https://chromium-review.googlesource.com/1039586Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52941}
parent 2461fdfd
...@@ -44,6 +44,9 @@ class InterpreterData; ...@@ -44,6 +44,9 @@ class InterpreterData;
class Factory; class Factory;
class Zone; class Zone;
template <typename T>
class Signature;
struct UntaggedT {}; struct UntaggedT {};
struct IntegralT : UntaggedT {}; struct IntegralT : UntaggedT {};
......
...@@ -14,6 +14,10 @@ ...@@ -14,6 +14,10 @@
namespace v8 { namespace v8 {
namespace internal { namespace internal {
template <typename T>
class Signature;
namespace compiler { namespace compiler {
class V8_EXPORT_PRIVATE Int64Lowering { class V8_EXPORT_PRIVATE Int64Lowering {
......
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
#include "src/machine-type.h" #include "src/machine-type.h"
#include "src/reglist.h" #include "src/reglist.h"
#include "src/runtime/runtime.h" #include "src/runtime/runtime.h"
#include "src/signature.h"
#include "src/zone/zone.h" #include "src/zone/zone.h"
namespace v8 { namespace v8 {
......
...@@ -14,6 +14,10 @@ ...@@ -14,6 +14,10 @@
namespace v8 { namespace v8 {
namespace internal { namespace internal {
template <typename T>
class Signature;
namespace compiler { namespace compiler {
class SimdScalarLowering { class SimdScalarLowering {
......
...@@ -9,8 +9,6 @@ ...@@ -9,8 +9,6 @@
#include "src/base/bits.h" #include "src/base/bits.h"
#include "src/globals.h" #include "src/globals.h"
#include "src/signature.h"
#include "src/zone/zone.h"
namespace v8 { namespace v8 {
namespace internal { namespace internal {
...@@ -294,8 +292,6 @@ V8_EXPORT_PRIVATE inline int ElementSizeLog2Of(MachineRepresentation rep) { ...@@ -294,8 +292,6 @@ V8_EXPORT_PRIVATE inline int ElementSizeLog2Of(MachineRepresentation rep) {
UNREACHABLE(); UNREACHABLE();
} }
typedef Signature<MachineType> MachineSignature;
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#define V8_SIGNATURE_H_ #define V8_SIGNATURE_H_
#include "src/base/iterator.h" #include "src/base/iterator.h"
#include "src/machine-type.h"
#include "src/zone/zone.h" #include "src/zone/zone.h"
namespace v8 { namespace v8 {
...@@ -98,6 +99,8 @@ class Signature : public ZoneObject { ...@@ -98,6 +99,8 @@ class Signature : public ZoneObject {
const T* reps_; const T* reps_;
}; };
typedef Signature<MachineType> MachineSignature;
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
......
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#include "src/wasm/local-decl-encoder.h" #include "src/wasm/local-decl-encoder.h"
#include "src/signature.h"
#include "src/wasm/leb-helper.h" #include "src/wasm/leb-helper.h"
namespace v8 { namespace v8 {
......
...@@ -9,9 +9,9 @@ ...@@ -9,9 +9,9 @@
#include "src/debug/debug.h" #include "src/debug/debug.h"
#include "src/debug/interface-types.h" #include "src/debug/interface-types.h"
#include "src/heap/heap.h" #include "src/heap/heap.h"
#include "src/machine-type.h"
#include "src/objects.h" #include "src/objects.h"
#include "src/objects/script.h" #include "src/objects/script.h"
#include "src/signature.h"
// Has to be the last include (doesn't have include guards) // Has to be the last include (doesn't have include guards)
#include "src/objects/object-macros.h" #include "src/objects/object-macros.h"
......
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#define V8_WASM_WASM_OPCODES_H_ #define V8_WASM_WASM_OPCODES_H_
#include "src/globals.h" #include "src/globals.h"
#include "src/vector.h"
#include "src/wasm/value-type.h" #include "src/wasm/value-type.h"
#include "src/wasm/wasm-constants.h" #include "src/wasm/wasm-constants.h"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment