Commit 643d69f7 authored by Lu Yahan's avatar Lu Yahan Committed by V8 LUCI CQ

[riscv64] Optmize load float zero

Change-Id: Ia651b26af419a2187217b8b0f2941ff61a17d247
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3712913
Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
Reviewed-by: 's avatarji qiu <qiuji@iscas.ac.cn>
Commit-Queue: ji qiu <qiuji@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#81257}
parent c878117f
......@@ -2406,6 +2406,7 @@ void TurboAssembler::InsertLowWordF64(FPURegister dst, Register src_low) {
}
void TurboAssembler::LoadFPRImmediate(FPURegister dst, uint32_t src) {
ASM_CODE_COMMENT(this);
// Handle special values first.
if (src == base::bit_cast<uint32_t>(0.0f) && has_single_zero_reg_set_) {
if (dst != kDoubleRegZero) fmv_s(dst, kDoubleRegZero);
......@@ -2415,19 +2416,24 @@ void TurboAssembler::LoadFPRImmediate(FPURegister dst, uint32_t src) {
} else {
if (dst == kDoubleRegZero) {
DCHECK(src == base::bit_cast<uint32_t>(0.0f));
fmv_w_x(dst, zero_reg);
fcvt_s_w(dst, zero_reg);
has_single_zero_reg_set_ = true;
has_double_zero_reg_set_ = false;
} else {
UseScratchRegisterScope temps(this);
Register scratch = temps.Acquire();
li(scratch, Operand(static_cast<int32_t>(src)));
fmv_w_x(dst, scratch);
if (src == base::bit_cast<uint32_t>(0.0f)) {
fcvt_s_w(dst, zero_reg);
} else {
li(scratch, Operand(static_cast<int32_t>(src)));
fmv_w_x(dst, scratch);
}
}
}
}
void TurboAssembler::LoadFPRImmediate(FPURegister dst, uint64_t src) {
ASM_CODE_COMMENT(this);
// Handle special values first.
if (src == base::bit_cast<uint64_t>(0.0) && has_double_zero_reg_set_) {
if (dst != kDoubleRegZero) fmv_d(dst, kDoubleRegZero);
......@@ -2437,14 +2443,18 @@ void TurboAssembler::LoadFPRImmediate(FPURegister dst, uint64_t src) {
} else {
if (dst == kDoubleRegZero) {
DCHECK(src == base::bit_cast<uint64_t>(0.0));
fmv_d_x(dst, zero_reg);
fcvt_d_l(dst, zero_reg);
has_double_zero_reg_set_ = true;
has_single_zero_reg_set_ = false;
} else {
UseScratchRegisterScope temps(this);
Register scratch = temps.Acquire();
li(scratch, Operand(src));
fmv_d_x(dst, scratch);
if (src == base::bit_cast<uint64_t>(0.0)) {
fcvt_d_l(dst, zero_reg);
} else {
li(scratch, Operand(src));
fmv_d_x(dst, scratch);
}
}
}
}
......@@ -3624,7 +3634,12 @@ void TurboAssembler::FPUCanonicalizeNaN(const DoubleRegister dst,
// Subtracting 0.0 preserves all inputs except for signalling NaNs, which
// become quiet NaNs. We use fsub rather than fadd because fsub preserves -0.0
// inputs: -0.0 + 0.0 = 0.0, but -0.0 - 0.0 = -0.0.
fsub_d(dst, src, kDoubleRegZero);
if (IsDoubleZeroRegSet()) {
fsub_d(dst, src, kDoubleRegZero);
} else {
LoadFPRImmediate(kDoubleRegZero, 0.0f);
fsub_d(dst, src, kDoubleRegZero);
}
}
void TurboAssembler::MovFromFloatResult(const DoubleRegister dst) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment