Commit 643ae467 authored by Joshua Litt's avatar Joshua Litt Committed by Commit Bot

[protectors] Remove invalid DCHECK in protectors.

The native context can differ from the current isolates
raw_native_context, so this DCHECK was never valid.

Bug: chromium:1033966
Change-Id: Iecbbdf33a8645ffd6e8768f4ba0eb0292eca269f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1982582Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Joshua Litt <joshualitt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65577}
parent 37f15b89
...@@ -36,7 +36,6 @@ void TraceProtectorInvalidation(const char* protector_name) { ...@@ -36,7 +36,6 @@ void TraceProtectorInvalidation(const char* protector_name) {
#define INVALIDATE_PROTECTOR_ON_NATIVE_CONTEXT_DEFINITION(name, cell) \ #define INVALIDATE_PROTECTOR_ON_NATIVE_CONTEXT_DEFINITION(name, cell) \
void Protectors::Invalidate##name(Isolate* isolate, \ void Protectors::Invalidate##name(Isolate* isolate, \
Handle<NativeContext> native_context) { \ Handle<NativeContext> native_context) { \
DCHECK_EQ(*native_context, isolate->raw_native_context()); \
DCHECK(native_context->cell().value().IsSmi()); \ DCHECK(native_context->cell().value().IsSmi()); \
DCHECK(Is##name##Intact(native_context)); \ DCHECK(Is##name##Intact(native_context)); \
if (FLAG_trace_protector_invalidation) { \ if (FLAG_trace_protector_invalidation) { \
......
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
var regexp = Realm.global(Realm.createAllowCrossRealmAccess()).RegExp;
regexp.prototype.constructor = 1;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment