Lolcode candidate: Both Expression and FunctionLiteral define an accessor...
Lolcode candidate: Both Expression and FunctionLiteral define an accessor is_parenthesized(), which access different flags. FunctionLiteral derives from Expression. Given FunctionLiteral* a; a->is_parenthesized() const FunctionLiteral* b; b->is_parenthesized() the first accesses FunctionLiteral::IsParenthesized, the second accesses Expression::IsParenthesizedField. Since these are distinct uses, we could rename them based on their use: - Expression::is_parenthesized -> is_single_parenthesized Count # of parenthesis, for parsing & error handling: no parenthesis -> single parenthesis -> multi parenthesis - FunctionLiteral::eager_compile_hint() Hint from parser to compiler about whether the parser suggests this function for eager compilation. BUG= Review URL: https://codereview.chromium.org/1097723005 Cr-Commit-Position: refs/heads/master@{#28042}
Showing
Please
register
or
sign in
to comment