Commit 63b3d332 authored by Benoît Lizé's avatar Benoît Lizé Committed by V8 LUCI CQ

[builtins] Embedded builtins don't depend on RAM on Android

So don't test it.

This was changed in
https://chromium-review.googlesource.com/c/v8/v8/+/3596164, breaking
this test on low-RAM ARM64 Android devices.

Bug: v8:12814
Change-Id: I25caf748607c33f5f632eb5236643ea5e327f867
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596129Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80073}
parent 7a96cecc
......@@ -2454,9 +2454,13 @@ TEST(IsDebugActive) {
*debug_is_active = false;
}
#if !defined(V8_OS_ANDROID)
// Ensure that the kShortBuiltinCallsOldSpaceSizeThreshold constant can be used
// for detecting whether the machine has >= 4GB of physical memory by checking
// the max old space size.
//
// Not on Android as short builtins do not depend on RAM on this platform, see
// comment in isolate.cc.
TEST(ShortBuiltinCallsThreshold) {
if (!V8_SHORT_BUILTIN_CALLS_BOOL) return;
......@@ -2480,6 +2484,7 @@ TEST(ShortBuiltinCallsThreshold) {
i::Heap::GenerationSizesFromHeapSize(heap_size, &young, &old);
CHECK_GE(old, kShortBuiltinCallsOldSpaceSizeThreshold);
}
#endif // !defined(V8_OS_ANDROID)
TEST(CallBuiltin) {
Isolate* isolate(CcTest::InitIsolateOnce());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment