Disable zapping of global handles in release mode.

R=danno@chromium.org

Review URL: https://codereview.chromium.org/12984006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14028 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent a473e9a8
...@@ -401,7 +401,7 @@ ...@@ -401,7 +401,7 @@
}, # Debug }, # Debug
'Release': { 'Release': {
'variables': { 'variables': {
'v8_enable_extra_checks%': 1, 'v8_enable_extra_checks%': 0,
}, },
'conditions': [ 'conditions': [
['v8_enable_extra_checks==1', { ['v8_enable_extra_checks==1', {
......
...@@ -72,7 +72,7 @@ class GlobalHandles::Node { ...@@ -72,7 +72,7 @@ class GlobalHandles::Node {
Internals::kNodeIsPartiallyDependentShift); Internals::kNodeIsPartiallyDependentShift);
} }
#ifdef DEBUG #ifdef ENABLE_EXTRA_CHECKS
~Node() { ~Node() {
// TODO(1428): if it's a weak handle we should have invoked its callback. // TODO(1428): if it's a weak handle we should have invoked its callback.
// Zap the values for eager trapping. // Zap the values for eager trapping.
...@@ -111,10 +111,9 @@ class GlobalHandles::Node { ...@@ -111,10 +111,9 @@ class GlobalHandles::Node {
void Release(GlobalHandles* global_handles) { void Release(GlobalHandles* global_handles) {
ASSERT(state() != FREE); ASSERT(state() != FREE);
set_state(FREE); set_state(FREE);
// TODO(mstarzinger): Put behind debug flag once embedders are stabilized. #ifdef ENABLE_EXTRA_CHECKS
object_ = reinterpret_cast<Object*>(kGlobalHandleZapValue);
#ifdef DEBUG
// Zap the values for eager trapping. // Zap the values for eager trapping.
object_ = reinterpret_cast<Object*>(kGlobalHandleZapValue);
class_id_ = v8::HeapProfiler::kPersistentHandleNoClassId; class_id_ = v8::HeapProfiler::kPersistentHandleNoClassId;
set_independent(false); set_independent(false);
set_partially_dependent(false); set_partially_dependent(false);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment