Commit 61c344e6 authored by Jon Kunkee's avatar Jon Kunkee Committed by Commit Bot

Fix namespace of ARM64 Windows FlushInstructionCache call

In the current version of the MSVC toolchain, it seems that the
compiler finds a near-match for the FlushInstructionCache call in
v8::internal::, so instead of looking in other namespaces for matching
overrides it emits this error:

C2660: 'v8::internal::FlushInstructionCache': function does not take 3 arguments

This change works around this by explicitly stating the expected
namespace.

Bug: chromium:927113
Change-Id: Ie39d6fdd458646fc86a4a2b16a93d6888ef1a5ae
Reviewed-on: https://chromium-review.googlesource.com/c/1462260Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59644}
parent 2e3f3950
......@@ -39,7 +39,7 @@ class CacheLineSizes {
void CpuFeatures::FlushICache(void* address, size_t length) {
#if defined(V8_OS_WIN)
FlushInstructionCache(GetCurrentProcess(), address, length);
::FlushInstructionCache(GetCurrentProcess(), address, length);
#elif defined(V8_HOST_ARCH_ARM64)
// The code below assumes user space cache operations are allowed. The goal
// of this routine is to make sure the code generated is visible to the I
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment