Commit 61af2762 authored by Camillo Bruni's avatar Camillo Bruni Committed by Commit Bot

[CSA] Temporarily disable bounds check in CSA::LoadArrayElement

Loading the length from a PropertyArray is currently broken.

Bug: v8:7732
Change-Id: Ia05f314f2f4822a8821801889b7a58f75b3f198c
Reviewed-on: https://chromium-review.googlesource.com/1049610Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53067}
parent 369b4476
......@@ -1773,11 +1773,7 @@ TNode<MaybeObject> CodeStubAssembler::LoadArrayElement(
STATIC_ASSERT(FixedArrayBase::kLengthOffset == WeakFixedArray::kLengthOffset);
// Check that index_node + additional_offset <= object.length.
// TODO(cbruni): Use proper LoadXXLength helpers
CSA_SLOW_ASSERT(
this,
IsOffsetInBounds(
offset, LoadAndUntagObjectField(array, FixedArrayBase::kLengthOffset),
FixedArray::kHeaderSize));
// TODO(cbruni): Re-add bounds check here.
return UncheckedCast<MaybeObject>(
Load(MachineType::AnyTagged(), array, offset, needs_poisoning));
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment