Commit 604f6614 authored by Alexander Schulze's avatar Alexander Schulze Committed by V8 LUCI CQ

[v8] Migrate compare_torque_output to py3

R=liviurau@chromium.org, machenbach@chromium.org

Bug: chromium:1292010
Change-Id: Ice96bda42e1597b7d266cafb61565a54ea96d9a8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3448374Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarLiviu Rau <liviurau@chromium.org>
Commit-Queue: Alexander Schulze <alexschulze@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78997}
parent 3aa7a85c
#!/usr/bin/env python #!/usr/bin/env python3
# Copyright 2020 the V8 project authors. All rights reserved. # Copyright 2020 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
......
#!/usr/bin/env python #!/usr/bin/env python3
# Copyright 2020 the V8 project authors. All rights reserved. # Copyright 2020 the V8 project authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be # Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file. # found in the LICENSE file.
...@@ -14,6 +14,11 @@ TOOLS_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__))) ...@@ -14,6 +14,11 @@ TOOLS_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
COMPARE_SCRIPT = os.path.join(TOOLS_DIR, 'compare_torque_output.py') COMPARE_SCRIPT = os.path.join(TOOLS_DIR, 'compare_torque_output.py')
TEST_DATA = os.path.join(TOOLS_DIR, 'unittests', 'testdata', 'compare_torque') TEST_DATA = os.path.join(TOOLS_DIR, 'unittests', 'testdata', 'compare_torque')
_PY3 = sys.version_info[0] == 3
PYTHON_EXECUTABLE = "python%s" % sys.version_info[0]
def maybe_bytes(value):
return value.decode("utf-8") if _PY3 else value
class PredictableTest(unittest.TestCase): class PredictableTest(unittest.TestCase):
def setUp(self): def setUp(self):
...@@ -24,7 +29,7 @@ class PredictableTest(unittest.TestCase): ...@@ -24,7 +29,7 @@ class PredictableTest(unittest.TestCase):
file1 = os.path.join(TEST_DATA, test_folder, 'f1') file1 = os.path.join(TEST_DATA, test_folder, 'f1')
file2 = os.path.join(TEST_DATA, test_folder, 'f2') file2 = os.path.join(TEST_DATA, test_folder, 'f2')
proc = subprocess.Popen([ proc = subprocess.Popen([
'python', '-u', PYTHON_EXECUTABLE, '-u',
COMPARE_SCRIPT, file1, file2, self.tmp_file COMPARE_SCRIPT, file1, file2, self.tmp_file
], stdout=subprocess.PIPE, stderr=subprocess.PIPE) ], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
_, err = proc.communicate() _, err = proc.communicate()
...@@ -34,7 +39,7 @@ class PredictableTest(unittest.TestCase): ...@@ -34,7 +39,7 @@ class PredictableTest(unittest.TestCase):
exitcode, output = self._compare_from('test1') exitcode, output = self._compare_from('test1')
self.assertEqual(1, exitcode) self.assertEqual(1, exitcode)
full_match = r'^Found.*-line 2\+line 2 with diff.*\+line 3\n\n$' full_match = r'^Found.*-line 2\+line 2 with diff.*\+line 3\n\n$'
self.assertRegexpMatches(output, re.compile(full_match, re.M | re.S)) self.assertRegexpMatches(maybe_bytes(output), re.compile(full_match, re.M | re.S))
def test_no_diff(self): def test_no_diff(self):
exitcode, output = self._compare_from('test2') exitcode, output = self._compare_from('test2')
...@@ -44,12 +49,12 @@ class PredictableTest(unittest.TestCase): ...@@ -44,12 +49,12 @@ class PredictableTest(unittest.TestCase):
def test_right_only(self): def test_right_only(self):
exitcode, output = self._compare_from('test3') exitcode, output = self._compare_from('test3')
self.assertEqual(1, exitcode) self.assertEqual(1, exitcode)
self.assertRegexpMatches(output, r'Some files exist only in.*f2\nfile3') self.assertRegexpMatches(maybe_bytes(output), r'Some files exist only in.*f2\nfile3')
def test_left_only(self): def test_left_only(self):
exitcode, output = self._compare_from('test4') exitcode, output = self._compare_from('test4')
self.assertEqual(1, exitcode) self.assertEqual(1, exitcode)
self.assertRegexpMatches(output, r'Some files exist only in.*f1\nfile4') self.assertRegexpMatches(maybe_bytes(output), r'Some files exist only in.*f1\nfile4')
def tearDown(self): def tearDown(self):
os.unlink(self.tmp_file) os.unlink(self.tmp_file)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment