Fix tests after r3811.

TBR=sgjesse@chromium.org

Review URL: http://codereview.chromium.org/574027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3813 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 8c29d246
...@@ -80,19 +80,3 @@ ...@@ -80,19 +80,3 @@
assertEquals('bbbbaaaa', reader.expandBackRef_('bbbb#2:4')); assertEquals('bbbbaaaa', reader.expandBackRef_('bbbb#2:4'));
assertEquals('"#1:1"', reader.expandBackRef_('"#1:1"')); assertEquals('"#1:1"', reader.expandBackRef_('"#1:1"'));
})(); })();
// See http://code.google.com/p/v8/issues/detail?id=420
(function testReadingTruncatedLog() {
// Having an incorrect event in the middle of a log should throw an exception.
var reader1 = new devtools.profiler.LogReader({});
assertThrows(function() {
reader1.processLogChunk('alias,a,b\nxxxx\nalias,c,d\n');
});
// But having it as the last record should not.
var reader2 = new devtools.profiler.LogReader({});
assertDoesNotThrow(function() {
reader2.processLogChunk('alias,a,b\nalias,c,d\nxxxx');
});
})();
...@@ -379,9 +379,7 @@ function driveTickProcessorTest( ...@@ -379,9 +379,7 @@ function driveTickProcessorTest(
var tp = new TickProcessor( var tp = new TickProcessor(
new CppEntriesProviderMock(), separateIc, ignoreUnknown, stateFilter); new CppEntriesProviderMock(), separateIc, ignoreUnknown, stateFilter);
var pm = new PrintMonitor(testsPath + refOutput); var pm = new PrintMonitor(testsPath + refOutput);
tp.processLogFile(testsPath + logInput); tp.processLogFileInTest(testsPath + logInput);
// Hack file name to avoid dealing with platform specifics.
tp.lastLogFileName_ = 'v8.log';
tp.printStatistics(); tp.printStatistics();
pm.finish(); pm.finish();
}; };
......
...@@ -269,6 +269,14 @@ TickProcessor.prototype.processLogFile = function(fileName) { ...@@ -269,6 +269,14 @@ TickProcessor.prototype.processLogFile = function(fileName) {
}; };
TickProcessor.prototype.processLogFileInTest = function(fileName) {
// Hack file name to avoid dealing with platform specifics.
this.lastLogFileName_ = 'v8.log';
var contents = readFile(fileName);
this.processLogChunk(contents);
};
TickProcessor.prototype.processSharedLibrary = function( TickProcessor.prototype.processSharedLibrary = function(
name, startAddr, endAddr) { name, startAddr, endAddr) {
var entry = this.profile_.addLibrary(name, startAddr, endAddr); var entry = this.profile_.addLibrary(name, startAddr, endAddr);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment