Commit 5e6fd798 authored by Michal Majewski's avatar Michal Majewski Committed by Commit Bot

[test] Fixed target_name in json progress indicator

Pass shell name instead of an absolute path.

Bug: v8:796166
Change-Id: Ia9472e893fd2cb3fde2a94997f3e9daf30da06ea
Reviewed-on: https://chromium-review.googlesource.com/833917
Commit-Queue: Michał Majewski <majeski@google.com>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50207}
parent 21a62391
......@@ -60,7 +60,7 @@ class TestSuite(testsuite.TestSuite):
class TestCase(testcase.TestCase):
def _get_shell(self):
def get_shell(self):
return SHELL
def _get_files_params(self, ctx):
......
......@@ -56,7 +56,7 @@ class TestCase(testcase.TestCase):
def _get_mode_flags(self, ctx):
return []
def _get_shell(self):
def get_shell(self):
group, _ = self.path.split('/', 1)
return 'v8_simple_%s_fuzzer' % group
......
......@@ -109,7 +109,7 @@ class TestCase(testcase.TestCase):
def _get_source_path(self):
return os.path.join(self.suite.root, self.path + self._get_suffix())
def _get_shell(self):
def get_shell(self):
return 'inspector-test'
......
......@@ -50,7 +50,7 @@ class TestCase(testcase.TestCase):
def _get_mode_flags(self, ctx):
return []
def _get_shell(self):
def get_shell(self):
return SHELL
......
......@@ -62,7 +62,7 @@ class TestCase(testcase.TestCase):
["--gtest_print_time=0"]
)
def _get_shell(self):
def get_shell(self):
return self.suite.name
......
......@@ -363,7 +363,7 @@ class JsonTestProgressIndicator(ProgressIndicator):
# TODO(machenbach): This stores only the global random seed from the
# context and not possible overrides when using random-seed stress.
"random_seed": self.random_seed,
"target_name": test.cmd.shell,
"target_name": test.get_shell(),
"variant": test.variant,
})
......
......@@ -183,7 +183,7 @@ class TestCase(object):
return []
def _get_shell_with_flags(self, ctx):
shell = self._get_shell()
shell = self.get_shell()
shell_flags = []
if shell == 'd8':
shell_flags.append('--test')
......@@ -203,7 +203,7 @@ class TestCase(object):
timeout *= 2
return timeout
def _get_shell(self):
def get_shell(self):
return 'd8'
def _get_suffix(self):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment