[deoptimizer, cleanup] Separating the implementation of GetFloatRegister

Trying to use double_registers for fetching single precision fp values creates
four different implementations of this method depending on the architecture, hence
separating them out into their respective folder.


Change-Id: Ide61fe2e7a95bd8427b377959b262633d8c57e61
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730663Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Milad Farazmand <miladfar@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#63042}

src/deoptimizer/arm/deoptimizer-arm.cc

@@ -221,6 +221,13 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
   __ stop();
 }
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  const int kShift = n % 2 == 0 ? 0 : 32;
+
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n / 2].get_bits() >> kShift));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/arm64/deoptimizer-arm64.cc

@@ -274,6 +274,11 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
   __ Br(continuation);
 }
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n].get_bits()));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return true; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/deoptimizer.h

@@ -635,18 +635,7 @@ class RegisterValues {
     return registers_[n];
   }
 
-  Float32 GetFloatRegister(unsigned n) const {
-    DCHECK(n < arraysize(double_registers_));
-    if (kSimpleFPAliasing) {
-      return Float32::FromBits(
-          static_cast<uint32_t>(double_registers_[n].get_bits()));
-    } else {
-      const int kShift = n % 2 == 0 ? 0 : 32;
-
-      return Float32::FromBits(
-          static_cast<uint32_t>(double_registers_[n / 2].get_bits() >> kShift));
-    }
-  }
+  Float32 GetFloatRegister(unsigned n) const;
 
   Float64 GetDoubleRegister(unsigned n) const {
     DCHECK(n < arraysize(double_registers_));

src/deoptimizer/ia32/deoptimizer-ia32.cc

@@ -199,6 +199,11 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
   __ ret(0);
 }
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n].get_bits()));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/mips/deoptimizer-mips.cc

@@ -218,6 +218,11 @@ const int Deoptimizer::table_entry_size_ = 2 * kInstrSize;
 const int Deoptimizer::table_entry_size_ = 3 * kInstrSize;
 #endif
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n].get_bits()));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/mips64/deoptimizer-mips64.cc

@@ -218,6 +218,11 @@ const int Deoptimizer::table_entry_size_ = 2 * kInstrSize;
 const int Deoptimizer::table_entry_size_ = 3 * kInstrSize;
 #endif
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n].get_bits()));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/ppc/deoptimizer-ppc.cc

@@ -219,6 +219,11 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
   __ stop();
 }
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  float float_val = static_cast<float>(double_registers_[n].get_scalar());
+  return Float32::FromBits(bit_cast<uint32_t>(float_val));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/s390/deoptimizer-s390.cc

@@ -212,6 +212,11 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
   __ stop();
 }
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n].get_bits() >> 32));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {

src/deoptimizer/x64/deoptimizer-x64.cc

@@ -215,6 +215,11 @@ void Deoptimizer::GenerateDeoptimizationEntries(MacroAssembler* masm,
   __ ret(0);
 }
 
+Float32 RegisterValues::GetFloatRegister(unsigned n) const {
+  return Float32::FromBits(
+      static_cast<uint32_t>(double_registers_[n].get_bits()));
+}
+
 bool Deoptimizer::PadTopOfStackRegister() { return false; }
 
 void FrameDescription::SetCallerPc(unsigned offset, intptr_t value) {