Commit 5d7cc775 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[Lite] Enable lazy source positions on V8 Lite mode

Also disables tests in Lite mode that currently fail with lazy source
positions.

Bug: v8:8510
Change-Id: Id27b7cb31682559173b137ef51eaf06d517ee9ec
Reviewed-on: https://chromium-review.googlesource.com/c/1477129
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59700}
parent b9dde931
...@@ -353,7 +353,7 @@ DEFINE_BOOL(ignition_share_named_property_feedback, true, ...@@ -353,7 +353,7 @@ DEFINE_BOOL(ignition_share_named_property_feedback, true,
"the same object") "the same object")
DEFINE_BOOL(print_bytecode, false, DEFINE_BOOL(print_bytecode, false,
"print bytecode generated by ignition interpreter") "print bytecode generated by ignition interpreter")
DEFINE_BOOL(enable_lazy_source_positions, false, DEFINE_BOOL(enable_lazy_source_positions, V8_LITE_BOOL,
"skip generating source positions during initial compile but " "skip generating source positions during initial compile but "
"regenerate when actually required") "regenerate when actually required")
DEFINE_STRING(print_bytecode_filter, "*", DEFINE_STRING(print_bytecode_filter, "*",
......
...@@ -574,6 +574,14 @@ ...@@ -574,6 +574,14 @@
'test-run-calls-to-external-references/*': [SKIP], 'test-run-calls-to-external-references/*': [SKIP],
}], # lite_mode or variant == jitless }], # lite_mode or variant == jitless
##############################################################################
['lite_mode', {
# TODO(v8:8510): Tests that currently fail with lazy source positions.
'test-cpu-profiler/TickLinesBaseline': [SKIP],
'test-cpu-profiler/TickLinesOptimized': [SKIP],
'test-cpu-profiler/Inlining2': [SKIP],
}], # lite_mode
############################################################################## ##############################################################################
['variant == jitless', { ['variant == jitless', {
# https://crbug.com/v8/7777 # https://crbug.com/v8/7777
......
...@@ -392,6 +392,12 @@ ...@@ -392,6 +392,12 @@
'regress/regress-crbug-898974': [SKIP], 'regress/regress-crbug-898974': [SKIP],
}], # 'lite_mode or variant == jitless' }], # 'lite_mode or variant == jitless'
##############################################################################
['lite_mode', {
# TODO(v8:8510): Tests that currently fail with lazy source positions.
'stack-traces-overflow': [SKIP],
}], # lite_mode
############################################################################## ##############################################################################
['variant == jitless', { ['variant == jitless', {
# https://crbug.com/v8/7777 # https://crbug.com/v8/7777
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment