Commit 5ca478a5 authored by ishell's avatar ishell Committed by Commit bot

[field type tracking] Fix handling of cleared WeakCells.

Previous CL (https://codereview.chromium.org/1522413002) has a typo.

BUG=chromium:571402,chromium:514080,chromium:527994,v8:4325
LOG=N

Review URL: https://codereview.chromium.org/1541403002

Cr-Commit-Position: refs/heads/master@{#33031}
parent 358efce0
......@@ -3833,8 +3833,8 @@ MaybeHandle<Map> Map::TryUpdate(Handle<Map> old_map) {
case DATA: {
HeapType* new_type = new_descriptors->GetFieldType(i);
// Cleared field types need special treatment. They represent lost
// knowledge, so we must first generalize the old_type to "Any".
if (!FieldTypeIsCleared(new_details.representation(), new_type)) {
// knowledge, so we must first generalize the new_type to "Any".
if (FieldTypeIsCleared(new_details.representation(), new_type)) {
return MaybeHandle<Map>();
}
PropertyType old_property_type = old_details.type();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment