Commit 5be70203 authored by alph@chromium.org's avatar alph@chromium.org

Make CPU profiler function names match ones from StackFrame iterator.

R=yangguo@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/417253003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22845 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 2083600a
...@@ -222,16 +222,16 @@ void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag, ...@@ -222,16 +222,16 @@ void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag,
} }
void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag, void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag, Code* code,
Code* code,
SharedFunctionInfo* shared, SharedFunctionInfo* shared,
CompilationInfo* info, CompilationInfo* info, Name* script_name) {
Name* name) {
if (FilterOutCodeCreateEvent(tag)) return; if (FilterOutCodeCreateEvent(tag)) return;
CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION); CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION);
CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_; CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_;
rec->start = code->address(); rec->start = code->address();
rec->entry = profiles_->NewCodeEntry(tag, profiles_->GetFunctionName(name)); rec->entry = profiles_->NewCodeEntry(
tag, profiles_->GetFunctionName(shared->DebugName()),
CodeEntry::kEmptyNamePrefix, profiles_->GetName(script_name));
if (info) { if (info) {
rec->entry->set_no_frame_ranges(info->ReleaseNoFrameRanges()); rec->entry->set_no_frame_ranges(info->ReleaseNoFrameRanges());
} }
...@@ -248,21 +248,17 @@ void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag, ...@@ -248,21 +248,17 @@ void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag,
} }
void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag, void CpuProfiler::CodeCreateEvent(Logger::LogEventsAndTags tag, Code* code,
Code* code,
SharedFunctionInfo* shared, SharedFunctionInfo* shared,
CompilationInfo* info, CompilationInfo* info, Name* script_name,
Name* source, int line, int column) { int line, int column) {
if (FilterOutCodeCreateEvent(tag)) return; if (FilterOutCodeCreateEvent(tag)) return;
CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION); CodeEventsContainer evt_rec(CodeEventRecord::CODE_CREATION);
CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_; CodeCreateEventRecord* rec = &evt_rec.CodeCreateEventRecord_;
rec->start = code->address(); rec->start = code->address();
rec->entry = profiles_->NewCodeEntry( rec->entry = profiles_->NewCodeEntry(
tag, tag, profiles_->GetFunctionName(shared->DebugName()),
profiles_->GetFunctionName(shared->DebugName()), CodeEntry::kEmptyNamePrefix, profiles_->GetName(script_name), line,
CodeEntry::kEmptyNamePrefix,
profiles_->GetName(source),
line,
column); column);
if (info) { if (info) {
rec->entry->set_no_frame_ranges(info->ReleaseNoFrameRanges()); rec->entry->set_no_frame_ranges(info->ReleaseNoFrameRanges());
......
...@@ -221,16 +221,13 @@ class CpuProfiler : public CodeEventListener { ...@@ -221,16 +221,13 @@ class CpuProfiler : public CodeEventListener {
Code* code, const char* comment); Code* code, const char* comment);
virtual void CodeCreateEvent(Logger::LogEventsAndTags tag, virtual void CodeCreateEvent(Logger::LogEventsAndTags tag,
Code* code, Name* name); Code* code, Name* name);
virtual void CodeCreateEvent(Logger::LogEventsAndTags tag, virtual void CodeCreateEvent(Logger::LogEventsAndTags tag, Code* code,
Code* code,
SharedFunctionInfo* shared, SharedFunctionInfo* shared,
CompilationInfo* info, CompilationInfo* info, Name* script_name);
Name* name); virtual void CodeCreateEvent(Logger::LogEventsAndTags tag, Code* code,
virtual void CodeCreateEvent(Logger::LogEventsAndTags tag,
Code* code,
SharedFunctionInfo* shared, SharedFunctionInfo* shared,
CompilationInfo* info, CompilationInfo* info, Name* script_name,
Name* source, int line, int column); int line, int column);
virtual void CodeCreateEvent(Logger::LogEventsAndTags tag, virtual void CodeCreateEvent(Logger::LogEventsAndTags tag,
Code* code, int args_count); Code* code, int args_count);
virtual void CodeMovingGCEvent() {} virtual void CodeMovingGCEvent() {}
......
...@@ -523,10 +523,7 @@ Handle<JSArray> Isolate::CaptureCurrentStackTrace( ...@@ -523,10 +523,7 @@ Handle<JSArray> Isolate::CaptureCurrentStackTrace(
} }
if (options & StackTrace::kFunctionName) { if (options & StackTrace::kFunctionName) {
Handle<Object> fun_name(fun->shared()->name(), this); Handle<Object> fun_name(fun->shared()->DebugName(), this);
if (!fun_name->BooleanValue()) {
fun_name = Handle<Object>(fun->shared()->inferred_name(), this);
}
JSObject::AddProperty(stack_frame, function_key, fun_name, NONE); JSObject::AddProperty(stack_frame, function_key, fun_name, NONE);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment