Commit 5b4626ad authored by rmcilroy's avatar rmcilroy Committed by Commit bot

[Interpreter] Enable TurboFan for Ignition variant tests.

Adds --turbo to the set of flags run with ignition (making the
configuration pure Ignition+TurboFan except for fallbacks to
full-codegen for catch / eval). Also changes the default
--ignition-filter to allow everything, rather than omit everything.

BUG=v8:4280
LOG=N

Review URL: https://codereview.chromium.org/1537433003

Cr-Commit-Position: refs/heads/master@{#33090}
parent ee665067
......@@ -295,7 +295,7 @@ DEFINE_BOOL(string_slices, true, "use string slices")
// Flags for Ignition.
DEFINE_BOOL(ignition, false, "use ignition interpreter")
DEFINE_STRING(ignition_filter, "~~", "filter for ignition interpreter")
DEFINE_STRING(ignition_filter, "*", "filter for ignition interpreter")
DEFINE_BOOL(ignition_fake_try_catch, false,
"enable fake try-catch-finally blocks in ignition for testing")
DEFINE_BOOL(ignition_fallback_on_eval_and_catch, false,
......
......@@ -776,63 +776,79 @@
'array-literal-transitions': [SKIP],
'array-reduce': [SKIP],
'array-tostring': [SKIP],
'assert-opt-and-deopt': [SKIP],
'big-array-literal': [SKIP],
'break': [SKIP],
'call-runtime-tail': [SKIP],
'comparison-ops-and-undefined': [SKIP],
'context-calls-maintained': [SKIP],
'contextual-calls': [SKIP],
'cross-realm-filtering': [SKIP],
'cyclic-array-to-string': [SKIP],
'd8-worker-sharedarraybuffer': [SKIP],
'delete-in-with': [SKIP],
'deopt-global-accessor': [SKIP],
'deopt-minus-zero': [SKIP],
'deopt-with-fp-regs': [SKIP],
'deserialize-optimize-inner': [SKIP],
'deserialize-script-id': [SKIP],
'div-mul-minus-one': [SKIP],
'double-equals': [SKIP],
'double-intrinsics': [SKIP],
'elements-transition-hoisting': [SKIP],
'eval-enclosing-function-name': [SKIP],
'eval-stack-trace': [SKIP],
'fast-prototype': [SKIP],
'field-type-tracking': [SKIP],
'for-in-opt': [SKIP],
'for-in-special-cases': [SKIP],
'function-call': [SKIP],
'get-caller-js-function': [SKIP],
'get-prototype-of': [SKIP],
'getter-in-prototype': [SKIP],
'getters-on-elements': [SKIP],
'global-hash': [SKIP],
'global-infinity': [SKIP],
'global-infinity-strict': [SKIP],
'global-load-from-eval-in-with': [SKIP],
'global-nan': [SKIP],
'global-nan-strict': [SKIP],
'global-undefined': [SKIP],
'global-undefined-strict': [SKIP],
'global-vars-with': [SKIP],
'instanceof-2': [SKIP],
'json': [SKIP],
'json-replacer-number-wrapper-tostring': [SKIP],
'json-replacer-order': [SKIP],
'math-floor-of-div-minus-zero': [SKIP],
'json': [SKIP],
'keyed-load-with-symbol-key': [SKIP],
'local-load-from-eval': [SKIP],
'math-min-max': [SKIP],
'messages': [SKIP],
'mirror-object': [SKIP],
'never-optimize': [SKIP],
'numops-fuzz-part1': [SKIP],
'numops-fuzz-part2': [SKIP],
'numops-fuzz-part3': [SKIP],
'numops-fuzz-part4': [SKIP],
'object-literal-gc': [SKIP],
'omit-constant-mapcheck': [SKIP],
'osr-elements-kind': [SKIP],
'property-load-across-eval': [SKIP],
'proto-accessor': [SKIP],
'readonly': [SKIP],
'receiver-in-with-calls': [SKIP],
'recursive-store-opt': [SKIP],
'regress-3225': [SKIP],
'regress/clear-keyed-call': [SKIP],
'regress/cross-script-vars': [SKIP],
'regress/poly_count_operation': [SKIP],
'regress/regress-102153': [SKIP],
'regress/regress-1030466': [SKIP],
'regress/regress-1079': [SKIP],
'regress/regress-109195': [SKIP],
'regress/regress-1114040': [SKIP],
'regress/regress-1125': [SKIP],
'regress/regress-1129': [SKIP],
'regress/regress-1170187': [SKIP],
'regress/regress-117409': [SKIP],
'regress/regress-1177809': [SKIP],
'regress/regress-119609': [SKIP],
'regress/regress-1209': [SKIP],
'regress/regress-123919': [SKIP],
'regress/regress-124594': [SKIP],
'regress/regress-124': [SKIP],
'regress/regress-125515': [SKIP],
......@@ -843,6 +859,8 @@
'regress/regress-1369': [SKIP],
'regress/regress-1403': [SKIP],
'regress/regress-1412': [SKIP],
'regress/regress-1423': [SKIP],
'regress/regress-1434': [SKIP],
'regress/regress-1436': [SKIP],
'regress/regress-1493017': [SKIP],
'regress/regress-1523': [SKIP],
......@@ -854,11 +872,13 @@
'regress/regress-1708': [SKIP],
'regress/regress-1757': [SKIP],
'regress/regress-1790': [SKIP],
'regress/regress-1853': [SKIP],
'regress/regress-1980': [SKIP],
'regress/regress-2054': [SKIP],
'regress/regress-2071': [SKIP],
'regress/regress-2132': [SKIP],
'regress/regress-2163': [SKIP],
'regress/regress-220': [SKIP],
'regress/regress-2315': [SKIP],
'regress/regress-2318': [SKIP],
'regress/regress-2339': [SKIP],
'regress/regress-2374': [SKIP],
......@@ -874,30 +894,33 @@
'regress/regress-286': [SKIP],
'regress/regress-298269': [SKIP],
'regress/regress-3135': [SKIP],
'regress/regress-3176': [SKIP],
'regress/regress-3138': [SKIP],
'regress/regress-318420': [SKIP],
'regress/regress-320532': [SKIP],
'regress/regress-3281': [SKIP],
'regress/regress-331444': [SKIP],
'regress/regress-343609': [SKIP],
'regress/regress-347530': [SKIP],
'regress/regress-347542': [SKIP],
'regress/regress-347914': [SKIP],
'regress/regress-351261': [SKIP],
'regress/regress-352982': [SKIP],
'regress/regress-353551': [SKIP],
'regress/regress-354357': [SKIP],
'regress/regress-356053': [SKIP],
'regress/regress-357105': [SKIP],
'regress/regress-359441': [SKIP],
'regress/regress-361025': [SKIP],
'regress/regress-3621': [SKIP],
'regress/regress-365172-3': [SKIP],
'regress/regress-370827': [SKIP],
'regress/regress-3709': [SKIP],
'regress/regress-377290': [SKIP],
'regress/regress-385565': [SKIP],
'regress/regress-3859': [SKIP],
'regress/regress-3884': [SKIP],
'regress/regress-3926': [SKIP],
'regress/regress-3960': [SKIP],
'regress/regress-3969': [SKIP],
'regress/regress-3985': [SKIP],
'regress/regress-4023': [SKIP],
'regress/regress-4027': [SKIP],
'regress/regress-403292': [SKIP],
......@@ -905,8 +928,8 @@
'regress/regress-4121': [SKIP],
'regress/regress-419663': [SKIP],
'regress/regress-4255-4': [SKIP],
'regress/regress-430201': [SKIP],
'regress/regress-430201b': [SKIP],
'regress/regress-430201': [SKIP],
'regress/regress-4309-3': [SKIP],
'regress/regress-4320': [SKIP],
'regress/regress-4325': [SKIP],
......@@ -922,13 +945,16 @@
'regress/regress-453481': [SKIP],
'regress/regress-4534': [SKIP],
'regress/regress-454725': [SKIP],
'regress/regress-457935': [SKIP],
'regress/regress-470804': [SKIP],
'regress/regress-476488': [SKIP],
'regress/regress-491536': [SKIP],
'regress/regress-503565': [SKIP],
'regress/regress-514362': [SKIP],
'regress/regress-520029': [SKIP],
'regress/regress-542099': [SKIP],
'regress/regress-542100': [SKIP],
'regress/regress-568765': [SKIP],
'regress/regress-580': [SKIP],
'regress/regress-618': [SKIP],
'regress/regress-643': [SKIP],
......@@ -936,6 +962,7 @@
'regress/regress-70066': [SKIP],
'regress/regress-747': [SKIP],
'regress/regress-753': [SKIP],
'regress/regress-799761': [SKIP],
'regress/regress-806473': [SKIP],
'regress/regress-842017': [SKIP],
'regress/regress-84234': [SKIP],
......@@ -948,35 +975,43 @@
'regress/regress-974': [SKIP],
'regress/regress-99167': [SKIP],
'regress/regress-998565': [SKIP],
'regress/regress-arg-materialize-store': [SKIP],
'regress/regress-arguments-gc': [SKIP],
'regress/regress-assignment-in-test-context': [SKIP],
'regress/regress-bce-underflow': [SKIP],
'regress/regress-cnlt-elements': [SKIP],
'regress/regress-cnlt-enum-indices': [SKIP],
'regress/regress-cntl-descriptors-enum': [SKIP],
'regress/regress-conditional-position': [SKIP],
'regress/regress-convert-enum': [SKIP],
'regress/regress-crbug-109362': [SKIP],
'regress/regress-crbug-119800': [SKIP],
'regress/regress-crbug-135008': [SKIP],
'regress/regress-crbug-163530': [SKIP],
'regress/regress-crbug-229923': [SKIP],
'regress/regress-crbug-242502': [SKIP],
'regress/regress-crbug-242924': [SKIP],
'regress/regress-crbug-245480': [SKIP],
'regress/regress-crbug-329709': [SKIP],
'regress/regress-crbug-336148': [SKIP],
'regress/regress-crbug-350864': [SKIP],
'regress/regress-crbug-351262': [SKIP],
'regress/regress-crbug-352058': [SKIP],
'regress/regress-353551': [SKIP],
'regress/regress-crbug-357137': [SKIP],
'regress/regress-crbug-385002': [SKIP],
'regress/regress-crbug-387599': [SKIP],
'regress/regress-crbug-405517': [SKIP],
'regress/regress-crbug-405922': [SKIP],
'regress/regress-crbug-409614': [SKIP],
'regress/regress-crbug-410033': [SKIP],
'regress/regress-crbug-412208': [SKIP],
'regress/regress-crbug-416558': [SKIP],
'regress/regress-crbug-424142': [SKIP],
'regress/regress-crbug-429159': [SKIP],
'regress/regress-crbug-431602': [SKIP],
'regress/regress-crbug-432493': [SKIP],
'regress/regress-crbug-450642': [SKIP],
'regress/regress-crbug-455644': [SKIP],
'regress/regress-crbug-465298': [SKIP],
'regress/regress-crbug-467180': [SKIP],
'regress/regress-crbug-467531': [SKIP],
......@@ -993,8 +1028,10 @@
'regress/regress-crbug-501809': [SKIP],
'regress/regress-crbug-506443': [SKIP],
'regress/regress-crbug-507070': [SKIP],
'regress/regress-crbug-510738': [SKIP],
'regress/regress-crbug-517592': [SKIP],
'regress/regress-crbug-522895': [SKIP],
'regress/regress-crbug-527364': [SKIP],
'regress/regress-crbug-530598': [SKIP],
'regress/regress-crbug-546968': [SKIP],
'regress/regress-crbug-568477-1': [SKIP],
'regress/regress-crbug-568477-2': [SKIP],
......@@ -1008,30 +1045,29 @@
'regress/regress-embedded-cons-string': [SKIP],
'regress/regress-existing-shared-function-info': [SKIP],
'regress/regress-fast-literal-transition': [SKIP],
'regress/regress-filter-contexts': [SKIP],
'regress/regress-function-constructor-receiver': [SKIP],
'regress/regress-handle-illegal-redeclaration': [SKIP],
'regress/regress-inline-class-constructor': [SKIP],
'regress/regress-inlining-function-literal-context': [SKIP],
'regress/regress-latin-1': [SKIP],
'regress/regress-lazy-deopt-reloc': [SKIP],
'regress/regress-map-invalidation-2': [SKIP],
'regress/regress-opt-after-debug-deopt': [SKIP],
'regress/regress-osr-in-case-label': [SKIP],
'regress/regress-osr-in-literal': [SKIP],
'regress/regress-param-local-type': [SKIP],
'regress/regress-prepare-break-while-recompile': [SKIP],
'regress/regress-put-prototype-transition': [SKIP],
'regress/regress-sliced-external-cons-regexp': [SKIP],
'regress/regress-store-heapobject': [SKIP],
'regress/regress-transcendental': [SKIP],
'regress/regress-typedarray-length': [SKIP],
'regress/regress-undefined-nan': [SKIP],
'regress/splice-missing-wb': [SKIP],
'shift-for-integer-div': [SKIP],
'simple-constructor': [SKIP],
'sin-cos': [SKIP],
'smi-mul-const': [SKIP],
'smi-mul': [SKIP],
'sparse-array-reverse': [SKIP],
'stack-traces': [SKIP],
'strict-mode-implicit-receiver': [SKIP],
'strict-mode': [SKIP],
'string-case': [SKIP],
'string-external-cached': [SKIP],
......@@ -1040,44 +1076,25 @@
'string-replace-with-empty': [SKIP],
'string-slices': [SKIP],
'switch-opt': [SKIP],
'switch': [SKIP],
'tail-call-intrinsic': [SKIP],
'tools/profile': [SKIP],
'tools/profviz': [SKIP],
'try-finally-continue': [SKIP],
'try': [SKIP],
'unary-minus-deopt': [SKIP],
'undetectable-compare': [SKIP],
'unused-context-in-with': [SKIP],
'value-wrapper': [SKIP],
'with-function-expression': [SKIP],
'with-parameter-access': [SKIP],
'with-prototype': [SKIP],
'with-readonly': [SKIP],
'regress/typed-array-lifetime': [SKIP],
'regress/regress-crbug-522895': [SKIP],
'regress/regress-crbug-455644': [SKIP],
'regress/regress-crbug-109362': [SKIP],
'regress/regress-crbug-429159': [SKIP],
'regress/regress-crbug-517592': [SKIP],
'regress/regress-crbug-405517': [SKIP],
'regress/regress-799761': [SKIP],
'regress/regress-503565': [SKIP],
'regress/regress-568765': [SKIP],
'regress/regress-3138': [SKIP],
'regress/regress-220': [SKIP],
'regress/regress-1170187': [SKIP],
'regress/regress-1030466': [SKIP],
'regress/regress-1853': [SKIP],
'with-value': [SKIP],
'with-function-expression': [SKIP],
'switch': [SKIP],
'receiver-in-with-calls': [SKIP],
'local-load-from-eval': [SKIP],
'deserialize-optimize-inner': [SKIP],
'delete-in-with': [SKIP],
}], # ignition == True
['ignition == True and (arch == arm or arch == arm64)', {
'array-sort': [SKIP],
'array-store-and-grow': [SKIP],
'date-parse': [SKIP],
'math-floor-part1': [SKIP],
'math-floor-part2': [SKIP],
......@@ -1097,6 +1114,17 @@
'regress/regress-crbug-500497': [SKIP],
'regress/regress-crbug-505007-1': [SKIP],
'regress/regress-crbug-505007-2': [SKIP],
'regress/regress-2193': [SKIP],
'regress/regress-3158': [SKIP],
'regress/regress-347904': [SKIP],
'regress/regress-380092': [SKIP],
'regress/regress-4173': [SKIP],
'regress/regress-copy-hole-to-field': [SKIP],
'regress/regress-crbug-315252': [SKIP],
'regress/regress-crbug-412215': [SKIP],
'regress/regress-deopt-store-effect': [SKIP],
'regress/regress-undefined-store-keyed-fast-element': [SKIP],
'regress/typed-array-lifetime': [SKIP],
'regress/short-circuit': [SKIP],
'stack-traces-overflow': [SKIP],
'unicodelctest': [SKIP],
......
......@@ -41,8 +41,7 @@ ALL_VARIANT_FLAGS = {
"turbofan": [["--turbo"]],
"turbofan_opt": [["--turbo", "--always-opt"]],
"nocrankshaft": [["--nocrankshaft"]],
"ignition": [["--ignition", "--ignition-filter=*",
"--ignition-fake-try-catch",
"ignition": [["--ignition", "--turbo", "--ignition-fake-try-catch",
"--ignition-fallback-on-eval-and-catch"]],
"preparser": [["--min-preparse-length=0"]],
}
......@@ -53,8 +52,7 @@ FAST_VARIANT_FLAGS = {
"stress": [["--stress-opt"]],
"turbofan": [["--turbo"]],
"nocrankshaft": [["--nocrankshaft"]],
"ignition": [["--ignition", "--ignition-filter=*",
"--ignition-fake-try-catch",
"ignition": [["--ignition", "--turbo", "--ignition-fake-try-catch",
"--ignition-fallback-on-eval-and-catch"]],
"preparser": [["--min-preparse-length=0"]],
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment