[wasm-simd][x64] Add instruction-selector tests for shuffles

I want to extract the Canonicalize shuffle out of the arch-specific
instruction selector, since all archs have to do that anyway. Adding
these tests to make sure the matching still works.

Bug: v8:11542
Change-Id: Ic7ce0e0a027ce858a30f79a0f9ef2495bcaab4c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2750289Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73414}

test/unittests/compiler/x64/instruction-selector-x64-unittest.cc

@@ -4,6 +4,7 @@
 
 #include <limits>
 
+#include "src/common/globals.h"
 #include "src/compiler/node-matchers.h"
 #include "src/objects/objects-inl.h"
 #include "test/unittests/compiler/backend/instruction-selector-unittest.h"
@@ -1888,6 +1889,9 @@ TEST_F(InstructionSelectorTest, LoadAndWord64ShiftRight32) {
   }
 }
 
+// -----------------------------------------------------------------------------
+// SIMD.
+
 TEST_F(InstructionSelectorTest, SIMDSplatZero) {
   // Test optimization for splat of contant 0.
   // {i8x16,i16x8,i32x4,i64x2}.splat(const(0)) -> v128.zero().
@@ -1935,6 +1939,240 @@ TEST_F(InstructionSelectorTest, SIMDSplatZero) {
   }
 }
 
+struct ArchShuffle {
+  uint8_t shuffle[kSimd128Size];
+  ArchOpcode arch_opcode;
+  size_t input_count;
+};
+
+static constexpr ArchShuffle kArchShuffles[] = {
+    // These are architecture specific shuffles defined in
+    // instruction-selecor-x64.cc arch_shuffles.
+    {
+        {0, 1, 2, 3, 4, 5, 6, 7, 16, 17, 18, 19, 20, 21, 22, 23},
+        kX64S64x2UnpackLow,
+        2,
+    },
+    {
+        {8, 9, 10, 11, 12, 13, 14, 15, 24, 25, 26, 27, 28, 29, 30, 31},
+        kX64S64x2UnpackHigh,
+        2,
+    },
+    {
+        {0, 1, 2, 3, 16, 17, 18, 19, 4, 5, 6, 7, 20, 21, 22, 23},
+        kX64S32x4UnpackLow,
+        2,
+    },
+    {
+        {8, 9, 10, 11, 24, 25, 26, 27, 12, 13, 14, 15, 28, 29, 30, 31},
+        kX64S32x4UnpackHigh,
+        2,
+    },
+    {
+        {0, 1, 16, 17, 2, 3, 18, 19, 4, 5, 20, 21, 6, 7, 22, 23},
+        kX64S16x8UnpackLow,
+        2,
+    },
+    {
+        {8, 9, 24, 25, 10, 11, 26, 27, 12, 13, 28, 29, 14, 15, 30, 31},
+        kX64S16x8UnpackHigh,
+        2,
+    },
+    {
+        {0, 16, 1, 17, 2, 18, 3, 19, 4, 20, 5, 21, 6, 22, 7, 23},
+        kX64S8x16UnpackLow,
+        2,
+    },
+    {
+        {8, 24, 9, 25, 10, 26, 11, 27, 12, 28, 13, 29, 14, 30, 15, 31},
+        kX64S8x16UnpackHigh,
+        2,
+    },
+    {
+        {0, 1, 4, 5, 8, 9, 12, 13, 16, 17, 20, 21, 24, 25, 28, 29},
+        kX64S16x8UnzipLow,
+        2,
+    },
+    {
+        {2, 3, 6, 7, 10, 11, 14, 15, 18, 19, 22, 23, 26, 27, 30, 31},
+        kX64S16x8UnzipHigh,
+        2,
+    },
+    {
+        {0, 2, 4, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24, 26, 28, 30},
+        kX64S8x16UnzipLow,
+        2,
+    },
+    {
+        {1, 3, 5, 7, 9, 11, 13, 15, 17, 19, 21, 23, 25, 27, 29, 31},
+        kX64S8x16UnzipHigh,
+        2,
+    },
+    {
+        {0, 16, 2, 18, 4, 20, 6, 22, 8, 24, 10, 26, 12, 28, 14, 30},
+        kX64S8x16TransposeLow,
+        2,
+    },
+    {
+        {1, 17, 3, 19, 5, 21, 7, 23, 9, 25, 11, 27, 13, 29, 15, 31},
+        kX64S8x16TransposeHigh,
+        2,
+    },
+    {
+        {7, 6, 5, 4, 3, 2, 1, 0, 15, 14, 13, 12, 11, 10, 9, 8},
+        kX64S8x8Reverse,
+        1,
+    },
+    {
+        {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8, 15, 14, 13, 12},
+        kX64S8x4Reverse,
+        1,
+    },
+    {
+        {1, 0, 3, 2, 5, 4, 7, 6, 9, 8, 11, 10, 13, 12, 15, 14},
+        kX64S8x2Reverse,
+        1,
+    },
+    // These are matched by TryMatchConcat && TryMatch32x4Rotate.
+    {
+        {4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 0, 1, 2, 3},
+        kX64S32x4Rotate,
+        2,
+    },
+    {
+        {8, 9, 10, 11, 12, 13, 14, 15, 0, 1, 2, 3, 4, 5, 6, 7},
+        kX64S32x4Rotate,
+        2,
+    },
+    {
+        {12, 13, 14, 15, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11},
+        kX64S32x4Rotate,
+        2,
+    },
+    // These are matched by TryMatchConcat && !TryMatch32x4Rotate.
+    {
+        {3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 0, 1, 2},
+        kX64S8x16Alignr,
+        3,
+    },
+    {
+        {2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 0, 1},
+        kX64S8x16Alignr,
+        3,
+    },
+    {
+        {2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17},
+        kX64S8x16Alignr,
+        3,
+    },
+    // These are matched by TryMatch32x4Shuffle && is_swizzle.
+    {
+        {0, 1, 2, 3, 8, 9, 10, 11, 4, 5, 6, 7, 12, 13, 14, 15},
+        kX64S32x4Swizzle,
+        2,
+    },
+    {
+        {0, 1, 2, 3, 4, 5, 6, 7, 12, 13, 14, 15, 8, 9, 10, 11},
+        kX64S32x4Swizzle,
+        2,
+    },
+    // These are matched by TryMatch32x4Shuffle && !is_swizzle && TryMatchBlend.
+    {
+        {0, 1, 2, 3, 20, 21, 22, 23, 8, 9, 10, 11, 28, 29, 30, 31},
+        kX64S16x8Blend,
+        3,
+    },
+    {
+        {16, 17, 18, 19, 4, 5, 6, 7, 24, 25, 26, 27, 12, 13, 14, 15},
+        kX64S16x8Blend,
+        3,
+    },
+    // These are matched by TryMatch32x4Shuffle && !is_swizzle &&
+    // TryMatchShufps.
+    {
+        {0, 1, 2, 3, 8, 9, 10, 11, 28, 29, 30, 31, 28, 29, 30, 31},
+        kX64Shufps,
+        3,
+    },
+    {
+        {8, 9, 10, 11, 0, 1, 2, 3, 28, 29, 30, 31, 28, 29, 30, 31},
+        kX64Shufps,
+        3,
+    },
+    // These are matched by TryMatch32x4Shuffle && !is_swizzle.
+    {
+        {28, 29, 30, 31, 0, 1, 2, 3, 28, 29, 30, 31, 28, 29, 30, 31},
+        kX64S32x4Shuffle,
+        4,
+    },
+    // These are matched by TryMatch16x8Shuffle && TryMatchBlend.
+    {
+        {16, 17, 2, 3, 4, 5, 6, 7, 24, 25, 26, 27, 12, 13, 14, 15},
+        kX64S16x8Blend,
+        3,
+    },
+    // These are matched by TryMatch16x8Shuffle && TryMatchSplat<8>.
+    {
+        {2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3},
+        kX64S16x8Dup,
+        2,
+    },
+    // These are matched by TryMatch16x8Shuffle && TryMatch16x8HalfShuffle.
+    {
+        {6, 7, 4, 5, 2, 3, 0, 1, 14, 15, 12, 13, 10, 11, 8, 9},
+        kX64S16x8HalfShuffle1,
+        3,
+    },
+    {
+        {6, 7, 4, 5, 2, 3, 0, 1, 30, 31, 28, 29, 26, 27, 24, 25},
+        kX64S16x8HalfShuffle2,
+        5,
+    },
+    // These are matched by TryMatchSplat<16>.
+    {
+        {1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1},
+        kX64S8x16Dup,
+        2,
+    },
+    // Generic shuffle that only uses 1 input.
+    {
+        {1, 15, 2, 14, 3, 13, 4, 12, 5, 11, 6, 10, 7, 9, 8},
+        kX64I8x16Shuffle,
+        5,
+    },
+    // Generic shuffle that uses both input.
+    {
+        {1, 31, 2, 14, 3, 13, 4, 12, 5, 11, 6, 10, 7, 9, 8},
+        kX64I8x16Shuffle,
+        6,
+    },
+};
+
+using InstructionSelectorSIMDArchShuffleTest =
+    InstructionSelectorTestWithParam<ArchShuffle>;
+
+TEST_P(InstructionSelectorSIMDArchShuffleTest, SIMDArchShuffle) {
+  MachineType type = MachineType::Simd128();
+  {
+    // Tests various shuffle optimizations
+    StreamBuilder m(this, type, type, type);
+    auto param = GetParam();
+    auto shuffle = param.shuffle;
+    const Operator* op = m.machine()->I8x16Shuffle(shuffle);
+    Node* n = m.AddNode(op, m.Parameter(0), m.Parameter(1));
+    m.Return(n);
+    Stream s = m.Build();
+    ASSERT_EQ(1U, s.size());
+    EXPECT_EQ(param.arch_opcode, s[0]->arch_opcode());
+    ASSERT_EQ(param.input_count, s[0]->InputCount());
+    EXPECT_EQ(1U, s[0]->OutputCount());
+  }
+}
+
+INSTANTIATE_TEST_SUITE_P(InstructionSelectorTest,
+                         InstructionSelectorSIMDArchShuffleTest,
+                         ::testing::ValuesIn(kArchShuffles));
+
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8