Commit 58fea9c1 authored by Maciej Goszczycki's avatar Maciej Goszczycki Committed by Commit Bot

[heap] Enable read-only heap sharing for lite-mode

Bug: v8:7464
Change-Id: I50de5f19f3303625a492faad5da378e2f0d3ed3f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602699Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Cr-Commit-Position: refs/heads/master@{#61514}
parent 61b56e19
...@@ -186,7 +186,8 @@ declare_args() { ...@@ -186,7 +186,8 @@ declare_args() {
v8_check_header_includes = false v8_check_header_includes = false
# Enable sharing read-only space across isolates. # Enable sharing read-only space across isolates.
v8_enable_shared_ro_heap = false # Sets -DV8_SHARED_RO_HEAP.
v8_enable_shared_ro_heap = ""
} }
# We reuse the snapshot toolchain for building torque and other generators to # We reuse the snapshot toolchain for building torque and other generators to
...@@ -224,6 +225,9 @@ if (v8_check_microtasks_scopes_consistency == "") { ...@@ -224,6 +225,9 @@ if (v8_check_microtasks_scopes_consistency == "") {
if (v8_enable_snapshot_native_code_counters == "") { if (v8_enable_snapshot_native_code_counters == "") {
v8_enable_snapshot_native_code_counters = v8_enable_debugging_features v8_enable_snapshot_native_code_counters = v8_enable_debugging_features
} }
if (v8_enable_shared_ro_heap == "") {
v8_enable_shared_ro_heap = v8_enable_lite_mode
}
assert(v8_current_cpu != "x86" || !v8_untrusted_code_mitigations, assert(v8_current_cpu != "x86" || !v8_untrusted_code_mitigations,
"Untrusted code mitigations are unsupported on ia32") "Untrusted code mitigations are unsupported on ia32")
...@@ -233,9 +237,6 @@ assert(!v8_enable_lite_mode || v8_enable_embedded_builtins, ...@@ -233,9 +237,6 @@ assert(!v8_enable_lite_mode || v8_enable_embedded_builtins,
assert(!v8_enable_lite_mode || v8_use_snapshot, assert(!v8_enable_lite_mode || v8_use_snapshot,
"Lite mode requires a snapshot build") "Lite mode requires a snapshot build")
assert(v8_use_snapshot || !v8_enable_shared_ro_heap,
"Nosnapshot builds are not supported with shared read-only heap enabled")
assert( assert(
!v8_enable_pointer_compression || !v8_enable_shared_ro_heap, !v8_enable_pointer_compression || !v8_enable_shared_ro_heap,
"Pointer compression is not supported with shared read-only heap enabled") "Pointer compression is not supported with shared read-only heap enabled")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment