Commit 58836f73 authored by Camillo Bruni's avatar Camillo Bruni Committed by V8 LUCI CQ

[api] Add warning comment about changing FatalProcessOutOfMemory

The signature of FatalProcessOutOfMemory is used extracting V8 specific
crash information from chrome minidumps.

Change-Id: I625a9ca1f1628c6ddd34cf794cc4205b012ef23e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532267Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79650}
parent 4fd61de7
...@@ -24,6 +24,8 @@ class V8 : public AllStatic { ...@@ -24,6 +24,8 @@ class V8 : public AllStatic {
// Report process out of memory. Implementation found in api.cc. // Report process out of memory. Implementation found in api.cc.
// This function will not return, but will terminate the execution. // This function will not return, but will terminate the execution.
// IMPORTANT: Update the Google-internal crash processer if this signature
// changes to be able to extract detailed v8::internal::HeapStats on OOM.
[[noreturn]] static void FatalProcessOutOfMemory(Isolate* isolate, [[noreturn]] static void FatalProcessOutOfMemory(Isolate* isolate,
const char* location, const char* location,
bool is_heap_oom = false); bool is_heap_oom = false);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment