Commit 58406c76 authored by Camillo Bruni's avatar Camillo Bruni Committed by V8 LUCI CQ

[builtins] Increase default buffer size

MSVC is not happy about conditionally increasing the buffer size for
builtin code generation with --code-comments.

Previous CL: https://crrev.com/c/2976651

Change-Id: Ic257eecfc9c41835d8ae4cf2de595fd5c427a7e2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992721Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75450}
parent 4ccebb6f
...@@ -31,6 +31,8 @@ BUILTIN_LIST_C(FORWARD_DECLARE) ...@@ -31,6 +31,8 @@ BUILTIN_LIST_C(FORWARD_DECLARE)
namespace { namespace {
const int kBufferSize = 128 * KB;
AssemblerOptions BuiltinAssemblerOptions(Isolate* isolate, Builtin builtin) { AssemblerOptions BuiltinAssemblerOptions(Isolate* isolate, Builtin builtin) {
AssemblerOptions options = AssemblerOptions::Default(isolate); AssemblerOptions options = AssemblerOptions::Default(isolate);
CHECK(!options.isolate_independent_code); CHECK(!options.isolate_independent_code);
...@@ -59,7 +61,6 @@ using CodeAssemblerGenerator = void (*)(compiler::CodeAssemblerState*); ...@@ -59,7 +61,6 @@ using CodeAssemblerGenerator = void (*)(compiler::CodeAssemblerState*);
Handle<Code> BuildPlaceholder(Isolate* isolate, Builtin builtin) { Handle<Code> BuildPlaceholder(Isolate* isolate, Builtin builtin) {
HandleScope scope(isolate); HandleScope scope(isolate);
const int kBufferSize = FLAG_code_comments ? 128 * KB : 1 * KB;
byte buffer[kBufferSize]; byte buffer[kBufferSize];
MacroAssembler masm(isolate, CodeObjectRequired::kYes, MacroAssembler masm(isolate, CodeObjectRequired::kYes,
ExternalAssemblerBuffer(buffer, kBufferSize)); ExternalAssemblerBuffer(buffer, kBufferSize));
...@@ -87,7 +88,6 @@ Code BuildWithMacroAssembler(Isolate* isolate, Builtin builtin, ...@@ -87,7 +88,6 @@ Code BuildWithMacroAssembler(Isolate* isolate, Builtin builtin,
// Canonicalize handles, so that we can share constant pool entries pointing // Canonicalize handles, so that we can share constant pool entries pointing
// to code targets without dereferencing their handles. // to code targets without dereferencing their handles.
CanonicalHandleScope canonical(isolate); CanonicalHandleScope canonical(isolate);
const int kBufferSize = FLAG_code_comments ? 128 * KB : 32 * KB;
byte buffer[kBufferSize]; byte buffer[kBufferSize];
MacroAssembler masm(isolate, BuiltinAssemblerOptions(isolate, builtin), MacroAssembler masm(isolate, BuiltinAssemblerOptions(isolate, builtin),
...@@ -130,7 +130,6 @@ Code BuildAdaptor(Isolate* isolate, Builtin builtin, Address builtin_address, ...@@ -130,7 +130,6 @@ Code BuildAdaptor(Isolate* isolate, Builtin builtin, Address builtin_address,
// Canonicalize handles, so that we can share constant pool entries pointing // Canonicalize handles, so that we can share constant pool entries pointing
// to code targets without dereferencing their handles. // to code targets without dereferencing their handles.
CanonicalHandleScope canonical(isolate); CanonicalHandleScope canonical(isolate);
const int kBufferSize = FLAG_code_comments ? 128 * KB : 32 * KB;
byte buffer[kBufferSize]; byte buffer[kBufferSize];
MacroAssembler masm(isolate, BuiltinAssemblerOptions(isolate, builtin), MacroAssembler masm(isolate, BuiltinAssemblerOptions(isolate, builtin),
CodeObjectRequired::kYes, CodeObjectRequired::kYes,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment