Commit 56baf018 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

Revert "Attempt to fix MSVC failure in test-debug/BreakPointJSBuiltin"

This reverts commit b342e611.

Reason for revert: x64 msvc failure

Original change's description:
> Attempt to fix MSVC failure in test-debug/BreakPointJSBuiltin
> 
> TBR=bmeurer@chromium.org
> 
> Bug: v8:178
> Change-Id: Idfa86749f3ee49c9f3b2a7fc7c0d7d3285e45c20
> Reviewed-on: https://chromium-review.googlesource.com/956066
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#51824}

TBR=yangguo@chromium.org,clemensh@chromium.org,bmeurer@chromium.org

Change-Id: I76c4df67416b982b3215df7dce23eb1e7d42ec4c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:178
Reviewed-on: https://chromium-review.googlesource.com/955572Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51825}
parent b342e611
...@@ -1179,7 +1179,7 @@ void Debug::InstallDebugBreakTrampoline() { ...@@ -1179,7 +1179,7 @@ void Debug::InstallDebugBreakTrampoline() {
if (!shared->HasDebugInfo()) continue; if (!shared->HasDebugInfo()) continue;
if (!shared->GetDebugInfo()->CanBreakAtEntry()) continue; if (!shared->GetDebugInfo()->CanBreakAtEntry()) continue;
if (!fun->is_compiled()) { if (!fun->is_compiled()) {
needs_compile.emplace_back(fun, isolate_); needs_compile.push_back(handle(fun));
} else { } else {
fun->set_code(*trampoline); fun->set_code(*trampoline);
} }
...@@ -1189,7 +1189,7 @@ void Debug::InstallDebugBreakTrampoline() { ...@@ -1189,7 +1189,7 @@ void Debug::InstallDebugBreakTrampoline() {
} }
// By overwriting the function code with DebugBreakTrampoline, which tailcalls // By overwriting the function code with DebugBreakTrampoline, which tailcalls
// to shared code, we bypass CompileLazy. Perform CompileLazy here instead. // to shared code, we bypass CompileLazy. Perform CompileLazy here instead.
for (const auto& fun : needs_compile) { for (Handle<JSFunction> fun : needs_compile) {
Compiler::Compile(fun, Compiler::CLEAR_EXCEPTION); Compiler::Compile(fun, Compiler::CLEAR_EXCEPTION);
fun->set_code(*trampoline); fun->set_code(*trampoline);
} }
......
...@@ -234,6 +234,8 @@ ...@@ -234,6 +234,8 @@
############################################################################## ##############################################################################
['system == windows', { ['system == windows', {
# BUG(178). Fails on windows.
'test-debug/BreakPointJSBuiltin': [SKIP],
# BUG(3331). Fails on windows. # BUG(3331). Fails on windows.
'test-heap/NoWeakHashTableLeakWithIncrementalMarking': [SKIP], 'test-heap/NoWeakHashTableLeakWithIncrementalMarking': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment