[cleanup] Remove unused CSA::BasicStoreNumberDictionaryElement

Last use of BasicStoreNumberDictionaryElement was removed in
https://chromium-review.googlesource.com/c/v8/v8/+/1627977

Bug: v8:9396
Change-Id: I08c1da67393c3549a8c756abd2a5ca4e35fa3b2a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822042
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63957}

src/builtins/base.tq

@@ -2935,8 +2935,6 @@ extern macro LoadConstructorOrBackPointer(Map): Object;
 
 extern macro BasicLoadNumberDictionaryElement(NumberDictionary, intptr): JSAny
     labels NotData, IfHole;
-extern macro BasicStoreNumberDictionaryElement(NumberDictionary, intptr, JSAny)
-    labels NotData, IfHole, ReadOnly;
 
 extern macro IsFastElementsKind(ElementsKind): bool;
 extern macro IsDoubleElementsKind(ElementsKind): bool;

src/codegen/code-stub-assembler.cc

@@ -8556,31 +8556,6 @@ TNode<Object> CodeStubAssembler::BasicLoadNumberDictionaryElement(
   return LoadValueByKeyIndex<NumberDictionary>(dictionary, index);
 }
 
-void CodeStubAssembler::BasicStoreNumberDictionaryElement(
-    TNode<NumberDictionary> dictionary, TNode<IntPtrT> intptr_index,
-    TNode<Object> value, Label* not_data, Label* if_hole, Label* read_only) {
-  TVARIABLE(IntPtrT, var_entry);
-  Label if_found(this);
-  NumberDictionaryLookup(dictionary, intptr_index, &if_found, &var_entry,
-                         if_hole);
-  BIND(&if_found);
-
-  // Check that the value is a data property.
-  TNode<IntPtrT> index = EntryToIndex<NumberDictionary>(var_entry.value());
-  TNode<Uint32T> details =
-      LoadDetailsByKeyIndex<NumberDictionary>(dictionary, index);
-  TNode<Uint32T> kind = DecodeWord32<PropertyDetails::KindField>(details);
-  // TODO(jkummerow): Support accessors without missing?
-  GotoIfNot(Word32Equal(kind, Int32Constant(kData)), not_data);
-
-  // Check that the property is writeable.
-  GotoIf(IsSetWord32(details, PropertyDetails::kAttributesReadOnlyMask),
-         read_only);
-
-  // Finally, store the value.
-  StoreValueByKeyIndex<NumberDictionary>(dictionary, index, value);
-}
-
 template <class Dictionary>
 void CodeStubAssembler::FindInsertionEntry(TNode<Dictionary> dictionary,
                                            TNode<Name> key,

src/codegen/code-stub-assembler.h

@@ -2994,10 +2994,6 @@ class V8_EXPORT_PRIVATE CodeStubAssembler
   TNode<Object> BasicLoadNumberDictionaryElement(
       TNode<NumberDictionary> dictionary, TNode<IntPtrT> intptr_index,
       Label* not_data, Label* if_hole);
-  void BasicStoreNumberDictionaryElement(TNode<NumberDictionary> dictionary,
-                                         TNode<IntPtrT> intptr_index,
-                                         TNode<Object> value, Label* not_data,
-                                         Label* if_hole, Label* read_only);
 
   template <class Dictionary>
   void FindInsertionEntry(TNode<Dictionary> dictionary, TNode<Name> key,