[cleanup] Remove Movability from globals.h

It was once widely used throughout v8 but now there is no need for it
anymore.

Bug: v8:9183
Change-Id: Id766987d468383cf459414eb5edfdee71b83a60b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585839
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61098}

src/globals.h

@@ -772,8 +772,6 @@ enum GarbageCollector { SCAVENGER, MARK_COMPACTOR, MINOR_MARK_COMPACTOR };
 
 enum Executability { NOT_EXECUTABLE, EXECUTABLE };
 
-enum Movability { kMovable, kImmovable };
-
 enum VisitMode {
   VISIT_ALL,
   VISIT_ALL_IN_MINOR_MC_MARK,

src/heap/factory.cc

@@ -105,7 +105,7 @@ MaybeHandle<Code> Factory::CodeBuilder::BuildInternal(bool failing_allocation) {
           heap->AllocateRawWithRetryOrFail(object_size, AllocationType::kCode);
     }
 
-    if (movability_ == kImmovable) {
+    if (!is_movable_) {
       result = heap->EnsureImmovableCode(result, object_size);
     }
 

src/heap/factory.h

@@ -969,7 +969,7 @@ class V8_EXPORT_PRIVATE Factory {
       return *this;
     }
     CodeBuilder& set_immovable() {
-      movability_ = kImmovable;
+      is_movable_ = false;
       return *this;
     }
     CodeBuilder& set_is_turbofanned() {
@@ -993,7 +993,7 @@ class V8_EXPORT_PRIVATE Factory {
     Handle<ByteArray> source_position_table_;
     Handle<DeoptimizationData> deoptimization_data_ =
         DeoptimizationData::Empty(isolate_);
-    Movability movability_ = kMovable;
+    bool is_movable_ = true;
     bool is_turbofanned_ = false;
     int stack_slots_ = 0;
   };