Commit 55b66b72 authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by V8 LUCI CQ

Revert "[compiler] Remove unused CodeDataContainerRef/Data classes"

This reverts commit 5fefa970.

Reason for revert: They are used via CodeT https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20external%20code%20space%20-%20debug%20-%20builder/124/overview

Original change's description:
> [compiler] Remove unused CodeDataContainerRef/Data classes
>
> Bug: v8:7790
> Change-Id: I072823ea40b0bd64aaf4a14882603cef29edcf22
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992722
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#75456}

Bug: v8:7790
Change-Id: I2c7f65c8a772de9967ce5b3aa78d1f46c9c99866
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996188Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75462}
parent 4ae31df1
......@@ -2300,6 +2300,15 @@ class CodeData : public HeapObjectData {
unsigned const inlined_bytecode_size_;
};
class CodeDataContainerData : public HeapObjectData {
public:
CodeDataContainerData(JSHeapBroker* broker, ObjectData** storage,
Handle<CodeDataContainer> object)
: HeapObjectData(broker, storage, object) {
DCHECK(!broker->is_concurrent_inlining());
}
};
#define DEFINE_IS(Name, ...) \
bool ObjectData::Is##Name() const { \
if (should_access_heap()) { \
......
......@@ -111,6 +111,7 @@ enum class RefSerializationKind {
V(CallHandlerInfo, RefSerializationKind::kNeverSerialized) \
V(Cell, RefSerializationKind::kNeverSerialized) \
V(Code, RefSerializationKind::kNeverSerialized) \
V(CodeDataContainer, RefSerializationKind::kNeverSerialized) \
V(Context, RefSerializationKind::kNeverSerialized) \
V(DescriptorArray, RefSerializationKind::kNeverSerialized) \
V(FeedbackCell, RefSerializationKind::kNeverSerialized) \
......@@ -1049,6 +1050,15 @@ class CodeRef : public HeapObjectRef {
unsigned GetInlinedBytecodeSize() const;
};
// CodeDataContainerRef doesn't appear to be used, but it is used via CodeT when
// V8_EXTERNAL_CODE_SPACE is defined.
class CodeDataContainerRef : public HeapObjectRef {
public:
DEFINE_REF_CONSTRUCTOR(CodeDataContainer, HeapObjectRef)
Handle<CodeDataContainer> object() const;
};
class InternalizedStringRef : public StringRef {
public:
DEFINE_REF_CONSTRUCTOR(InternalizedString, StringRef)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment