Skip to content

V
V8
Commit 5576ef61 authored by Shu-yu Guo's avatar Shu-yu Guo Committed by V8 LUCI CQ
Browse files
Options

[Object.hasOwn] Remove flag 

Object.hasOwn has shipped since 9.3.

Also drive-by removing other removed feature flags from test262 config.

Bug: chromium:1213927, v8:13220
Change-Id: I3d11298e1348adf5b26d63a23a6606a4ad22892c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863807
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82853}
parent 6904a812
Hide whitespace changes
Inline Side-by-side
Showing with 64 additions and 79 deletions
src/flags/flag-definitions.h
View file @ 5576ef61
......@@ -255,7 +255,6 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
#define HARMONY_SHIPPING_BASE(V) \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_object_has_own, "harmony Object.hasOwn") \
V(harmony_class_static_blocks, "harmony static initializer blocks") \
V(harmony_array_find_last, "harmony array find last helpers")
......
src/init/bootstrapper.cc
View file @ 5576ef61
......@@ -1589,6 +1589,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Builtin::kObjectGetOwnPropertyNames, 1, true);
SimpleInstallFunction(isolate_, object_function, "getOwnPropertySymbols",
Builtin::kObjectGetOwnPropertySymbols, 1, false);
SimpleInstallFunction(isolate_, object_function, "hasOwn",
Builtin::kObjectHasOwn, 2, true);
SimpleInstallFunction(isolate_, object_function, "is", Builtin::kObjectIs,
2, true);
SimpleInstallFunction(isolate_, object_function, "preventExtensions",
......@@ -4766,14 +4768,6 @@ void Genesis::InitializeGlobal_harmony_array_grouping() {
InstallTrueValuedProperty(isolate_, unscopables, "groupToMap");
}
void Genesis::InitializeGlobal_harmony_object_has_own() {
if (!FLAG_harmony_object_has_own) return;
Handle<JSFunction> object_function = isolate_->object_function();
SimpleInstallFunction(isolate_, object_function, "hasOwn",
Builtin::kObjectHasOwn, 2, true);
}
void Genesis::InitializeGlobal_harmony_sharedarraybuffer() {
if (!FLAG_harmony_sharedarraybuffer ||
FLAG_enable_sharedarraybuffer_per_context) {
......
test/mjsunit/harmony/has-own.js
View file @ 5576ef61
......@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --harmony-object-has-own
let object = { foo: false };
assertTrue((Object.hasOwn(object, "foo")));
......
test/test262/testcfg.py
View file @ 5576ef61
......@@ -47,13 +47,7 @@ FEATURE_FLAGS = {
'WeakRef': '--harmony-weak-refs-with-cleanup-some',
'host-gc-required': '--expose-gc-as=v8GC',
'IsHTMLDDA': '--allow-natives-syntax',
'top-level-await': '--harmony-top-level-await',
'regexp-match-indices': '--harmony-regexp-match-indices',
'regexp-named-groups': '--harmony-regexp-match-indices',
'error-cause': '--harmony-error-cause',
'import-assertions': '--harmony-import-assertions',
'Object.hasOwn': '--harmony-object-has-own',
'class-static-block': '--harmony-class-static-blocks',
'resizable-arraybuffer': '--harmony-rab-gsab',
'Temporal': '--harmony-temporal',
'array-find-from-last': '--harmony_array_find_last',
......
tools/v8heapconst.py
View file @ 5576ef61
......@@ -506,68 +506,68 @@ KNOWN_OBJECTS = {
("read_only_space", 0x04a85): "EmptyFunctionScopeInfo",
("read_only_space", 0x04aa9): "NativeScopeInfo",
("read_only_space", 0x04ac1): "HashSeed",
("old_space", 0x04221): "ArgumentsIteratorAccessor",
("old_space", 0x04241): "ArrayLengthAccessor",
("old_space", 0x04261): "BoundFunctionLengthAccessor",
("old_space", 0x04281): "BoundFunctionNameAccessor",
("old_space", 0x042a1): "ErrorStackAccessor",
("old_space", 0x042c1): "FunctionArgumentsAccessor",
("old_space", 0x042e1): "FunctionCallerAccessor",
("old_space", 0x04301): "FunctionNameAccessor",
("old_space", 0x04321): "FunctionLengthAccessor",
("old_space", 0x04341): "FunctionPrototypeAccessor",
("old_space", 0x04361): "SharedArrayLengthAccessor",
("old_space", 0x04381): "StringLengthAccessor",
("old_space", 0x043a1): "ValueUnavailableAccessor",
("old_space", 0x043c1): "WrappedFunctionLengthAccessor",
("old_space", 0x043e1): "WrappedFunctionNameAccessor",
("old_space", 0x04401): "InvalidPrototypeValidityCell",
("old_space", 0x04409): "EmptyScript",
("old_space", 0x0444d): "ManyClosuresCell",
("old_space", 0x04459): "ArrayConstructorProtector",
("old_space", 0x0446d): "NoElementsProtector",
("old_space", 0x04481): "MegaDOMProtector",
("old_space", 0x04495): "IsConcatSpreadableProtector",
("old_space", 0x044a9): "ArraySpeciesProtector",
("old_space", 0x044bd): "TypedArraySpeciesProtector",
("old_space", 0x044d1): "PromiseSpeciesProtector",
("old_space", 0x044e5): "RegExpSpeciesProtector",
("old_space", 0x044f9): "StringLengthProtector",
("old_space", 0x0450d): "ArrayIteratorProtector",
("old_space", 0x04521): "ArrayBufferDetachingProtector",
("old_space", 0x04535): "PromiseHookProtector",
("old_space", 0x04549): "PromiseResolveProtector",
("old_space", 0x0455d): "MapIteratorProtector",
("old_space", 0x04571): "PromiseThenProtector",
("old_space", 0x04585): "SetIteratorProtector",
("old_space", 0x04599): "StringIteratorProtector",
("old_space", 0x045ad): "StringSplitCache",
("old_space", 0x049b5): "RegExpMultipleCache",
("old_space", 0x04dbd): "BuiltinsConstantsTable",
("old_space", 0x0520d): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x05231): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x05255): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x05279): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x0529d): "AsyncGeneratorYieldResolveSharedFun",
("old_space", 0x052c1): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x052e5): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x05309): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x0532d): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x05351): "PromiseAllResolveElementSharedFun",
("old_space", 0x05375): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x05399): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x053bd): "PromiseAnyRejectElementSharedFun",
("old_space", 0x053e1): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x05405): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x05429): "PromiseCatchFinallySharedFun",
("old_space", 0x0544d): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x05471): "PromiseThenFinallySharedFun",
("old_space", 0x05495): "PromiseThrowerFinallySharedFun",
("old_space", 0x054b9): "PromiseValueThunkFinallySharedFun",
("old_space", 0x054dd): "ProxyRevokeSharedFun",
("old_space", 0x05501): "ShadowRealmImportValueFulfilledSFI",
("old_space", 0x05525): "SourceTextModuleExecuteAsyncModuleFulfilledSFI",
("old_space", 0x05549): "SourceTextModuleExecuteAsyncModuleRejectedSFI",
("old_space", 0x04235): "ArgumentsIteratorAccessor",
("old_space", 0x04255): "ArrayLengthAccessor",
("old_space", 0x04275): "BoundFunctionLengthAccessor",
("old_space", 0x04295): "BoundFunctionNameAccessor",
("old_space", 0x042b5): "ErrorStackAccessor",
("old_space", 0x042d5): "FunctionArgumentsAccessor",
("old_space", 0x042f5): "FunctionCallerAccessor",
("old_space", 0x04315): "FunctionNameAccessor",
("old_space", 0x04335): "FunctionLengthAccessor",
("old_space", 0x04355): "FunctionPrototypeAccessor",
("old_space", 0x04375): "SharedArrayLengthAccessor",
("old_space", 0x04395): "StringLengthAccessor",
("old_space", 0x043b5): "ValueUnavailableAccessor",
("old_space", 0x043d5): "WrappedFunctionLengthAccessor",
("old_space", 0x043f5): "WrappedFunctionNameAccessor",
("old_space", 0x04415): "InvalidPrototypeValidityCell",
("old_space", 0x0441d): "EmptyScript",
("old_space", 0x04461): "ManyClosuresCell",
("old_space", 0x0446d): "ArrayConstructorProtector",
("old_space", 0x04481): "NoElementsProtector",
("old_space", 0x04495): "MegaDOMProtector",
("old_space", 0x044a9): "IsConcatSpreadableProtector",
("old_space", 0x044bd): "ArraySpeciesProtector",
("old_space", 0x044d1): "TypedArraySpeciesProtector",
("old_space", 0x044e5): "PromiseSpeciesProtector",
("old_space", 0x044f9): "RegExpSpeciesProtector",
("old_space", 0x0450d): "StringLengthProtector",
("old_space", 0x04521): "ArrayIteratorProtector",
("old_space", 0x04535): "ArrayBufferDetachingProtector",
("old_space", 0x04549): "PromiseHookProtector",
("old_space", 0x0455d): "PromiseResolveProtector",
("old_space", 0x04571): "MapIteratorProtector",
("old_space", 0x04585): "PromiseThenProtector",
("old_space", 0x04599): "SetIteratorProtector",
("old_space", 0x045ad): "StringIteratorProtector",
("old_space", 0x045c1): "StringSplitCache",
("old_space", 0x049c9): "RegExpMultipleCache",
("old_space", 0x04dd1): "BuiltinsConstantsTable",
("old_space", 0x05221): "AsyncFunctionAwaitRejectSharedFun",
("old_space", 0x05245): "AsyncFunctionAwaitResolveSharedFun",
("old_space", 0x05269): "AsyncGeneratorAwaitRejectSharedFun",
("old_space", 0x0528d): "AsyncGeneratorAwaitResolveSharedFun",
("old_space", 0x052b1): "AsyncGeneratorYieldResolveSharedFun",
("old_space", 0x052d5): "AsyncGeneratorReturnResolveSharedFun",
("old_space", 0x052f9): "AsyncGeneratorReturnClosedRejectSharedFun",
("old_space", 0x0531d): "AsyncGeneratorReturnClosedResolveSharedFun",
("old_space", 0x05341): "AsyncIteratorValueUnwrapSharedFun",
("old_space", 0x05365): "PromiseAllResolveElementSharedFun",
("old_space", 0x05389): "PromiseAllSettledResolveElementSharedFun",
("old_space", 0x053ad): "PromiseAllSettledRejectElementSharedFun",
("old_space", 0x053d1): "PromiseAnyRejectElementSharedFun",
("old_space", 0x053f5): "PromiseCapabilityDefaultRejectSharedFun",
("old_space", 0x05419): "PromiseCapabilityDefaultResolveSharedFun",
("old_space", 0x0543d): "PromiseCatchFinallySharedFun",
("old_space", 0x05461): "PromiseGetCapabilitiesExecutorSharedFun",
("old_space", 0x05485): "PromiseThenFinallySharedFun",
("old_space", 0x054a9): "PromiseThrowerFinallySharedFun",
("old_space", 0x054cd): "PromiseValueThunkFinallySharedFun",
("old_space", 0x054f1): "ProxyRevokeSharedFun",
("old_space", 0x05515): "ShadowRealmImportValueFulfilledSFI",
("old_space", 0x05539): "SourceTextModuleExecuteAsyncModuleFulfilledSFI",
("old_space", 0x0555d): "SourceTextModuleExecuteAsyncModuleRejectedSFI",
}
# Lower 32 bits of first page addresses for various heap spaces.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment