Commit 54ea7158 authored by Sathya Gunasekaran's avatar Sathya Gunasekaran Committed by Commit Bot

Remove RequiresInstanceFieldInitializer bit from ParseInfo

This information is already stored in compiler_hints_. This saves 1
bit on ParseInfo.

Change-Id: I37927c256aacd18fb332b522989dc669aa80df01
Reviewed-on: https://chromium-review.googlesource.com/858427Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50483}
parent 463dbab3
...@@ -60,8 +60,6 @@ ParseInfo::ParseInfo(Handle<SharedFunctionInfo> shared) ...@@ -60,8 +60,6 @@ ParseInfo::ParseInfo(Handle<SharedFunctionInfo> shared)
function_literal_id_ = shared->function_literal_id(); function_literal_id_ = shared->function_literal_id();
set_language_mode(shared->language_mode()); set_language_mode(shared->language_mode());
set_asm_wasm_broken(shared->is_asm_wasm_broken()); set_asm_wasm_broken(shared->is_asm_wasm_broken());
set_requires_instance_fields_initializer(
shared->requires_instance_fields_initializer());
Handle<Script> script(Script::cast(shared->script())); Handle<Script> script(Script::cast(shared->script()));
set_script(script); set_script(script);
...@@ -158,6 +156,11 @@ FunctionKind ParseInfo::function_kind() const { ...@@ -158,6 +156,11 @@ FunctionKind ParseInfo::function_kind() const {
return SharedFunctionInfo::FunctionKindBits::decode(compiler_hints_); return SharedFunctionInfo::FunctionKindBits::decode(compiler_hints_);
} }
bool ParseInfo::requires_instance_fields_initializer() const {
return SharedFunctionInfo::RequiresInstanceFieldsInitializer::decode(
compiler_hints_);
}
void ParseInfo::InitFromIsolate(Isolate* isolate) { void ParseInfo::InitFromIsolate(Isolate* isolate) {
DCHECK_NOT_NULL(isolate); DCHECK_NOT_NULL(isolate);
set_hash_seed(isolate->heap()->HashSeed()); set_hash_seed(isolate->heap()->HashSeed());
......
...@@ -79,9 +79,6 @@ class V8_EXPORT_PRIVATE ParseInfo { ...@@ -79,9 +79,6 @@ class V8_EXPORT_PRIVATE ParseInfo {
FLAG_ACCESSOR(kCollectTypeProfile, collect_type_profile, FLAG_ACCESSOR(kCollectTypeProfile, collect_type_profile,
set_collect_type_profile) set_collect_type_profile)
FLAG_ACCESSOR(kIsAsmWasmBroken, is_asm_wasm_broken, set_asm_wasm_broken) FLAG_ACCESSOR(kIsAsmWasmBroken, is_asm_wasm_broken, set_asm_wasm_broken)
FLAG_ACCESSOR(kRequiresInstanceFieldsInitializer,
requires_instance_fields_initializer,
set_requires_instance_fields_initializer)
FLAG_ACCESSOR(kBlockCoverageEnabled, block_coverage_enabled, FLAG_ACCESSOR(kBlockCoverageEnabled, block_coverage_enabled,
set_block_coverage_enabled) set_block_coverage_enabled)
FLAG_ACCESSOR(kOnBackgroundThread, on_background_thread, FLAG_ACCESSOR(kOnBackgroundThread, on_background_thread,
...@@ -210,6 +207,7 @@ class V8_EXPORT_PRIVATE ParseInfo { ...@@ -210,6 +207,7 @@ class V8_EXPORT_PRIVATE ParseInfo {
// Getters for individual compiler hints. // Getters for individual compiler hints.
bool is_declaration() const; bool is_declaration() const;
FunctionKind function_kind() const; FunctionKind function_kind() const;
bool requires_instance_fields_initializer() const;
//-------------------------------------------------------------------------- //--------------------------------------------------------------------------
// TODO(titzer): these should not be part of ParseInfo. // TODO(titzer): these should not be part of ParseInfo.
...@@ -263,9 +261,8 @@ class V8_EXPORT_PRIVATE ParseInfo { ...@@ -263,9 +261,8 @@ class V8_EXPORT_PRIVATE ParseInfo {
kCollectTypeProfile = 1 << 10, kCollectTypeProfile = 1 << 10,
kBlockCoverageEnabled = 1 << 11, kBlockCoverageEnabled = 1 << 11,
kIsAsmWasmBroken = 1 << 12, kIsAsmWasmBroken = 1 << 12,
kRequiresInstanceFieldsInitializer = 1 << 13, kOnBackgroundThread = 1 << 13,
kOnBackgroundThread = 1 << 14, kWrappedAsFunction = 1 << 14, // Implicitly wrapped as function.
kWrappedAsFunction = 1 << 15, // Implicitly wrapped as function.
}; };
//------------- Inputs to parsing and scope analysis ----------------------- //------------- Inputs to parsing and scope analysis -----------------------
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment