Commit 54404c47 authored by titzer's avatar titzer Committed by Commit bot

Clean up some random TODO(titzer)s and spelling mistakes.

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1698473003

Cr-Commit-Position: refs/heads/master@{#33955}
parent a02df7e1
...@@ -768,7 +768,7 @@ void InstructionSelector::VisitControl(BasicBlock* block) { ...@@ -768,7 +768,7 @@ void InstructionSelector::VisitControl(BasicBlock* block) {
DCHECK_EQ(IrOpcode::kThrow, input->opcode()); DCHECK_EQ(IrOpcode::kThrow, input->opcode());
return VisitThrow(input->InputAt(0)); return VisitThrow(input->InputAt(0));
case BasicBlock::kNone: { case BasicBlock::kNone: {
// TODO(titzer): exit block doesn't have control. // Exit block doesn't have control.
DCHECK_NULL(input); DCHECK_NULL(input);
break; break;
} }
...@@ -1611,7 +1611,7 @@ void InstructionSelector::VisitDeoptimize(DeoptimizeKind kind, Node* value) { ...@@ -1611,7 +1611,7 @@ void InstructionSelector::VisitDeoptimize(DeoptimizeKind kind, Node* value) {
void InstructionSelector::VisitThrow(Node* value) { void InstructionSelector::VisitThrow(Node* value) {
OperandGenerator g(this); OperandGenerator g(this);
Emit(kArchThrowTerminator, g.NoOutput()); // TODO(titzer) Emit(kArchThrowTerminator, g.NoOutput());
} }
......
...@@ -97,7 +97,6 @@ bool Truncation::LessGeneral(TruncationKind rep1, TruncationKind rep2) { ...@@ -97,7 +97,6 @@ bool Truncation::LessGeneral(TruncationKind rep1, TruncationKind rep2) {
namespace { namespace {
// TODO(titzer): should Word64 also be implicitly convertable to others?
bool IsWord(MachineRepresentation rep) { bool IsWord(MachineRepresentation rep) {
return rep == MachineRepresentation::kWord8 || return rep == MachineRepresentation::kWord8 ||
rep == MachineRepresentation::kWord16 || rep == MachineRepresentation::kWord16 ||
......
...@@ -254,7 +254,6 @@ NO_THROW_OP_LIST(GET_FROM_CACHE) ...@@ -254,7 +254,6 @@ NO_THROW_OP_LIST(GET_FROM_CACHE)
const Operator* SimplifiedOperatorBuilder::ReferenceEqual(Type* type) { const Operator* SimplifiedOperatorBuilder::ReferenceEqual(Type* type) {
// TODO(titzer): What about the type parameter?
return new (zone()) Operator(IrOpcode::kReferenceEqual, return new (zone()) Operator(IrOpcode::kReferenceEqual,
Operator::kCommutative | Operator::kPure, Operator::kCommutative | Operator::kPure,
"ReferenceEqual", 2, 0, 0, 1, 0, 0); "ReferenceEqual", 2, 0, 0, 1, 0, 0);
......
...@@ -383,8 +383,8 @@ void Deoptimizer::DeoptimizeMarkedCodeForContext(Context* context) { ...@@ -383,8 +383,8 @@ void Deoptimizer::DeoptimizeMarkedCodeForContext(Context* context) {
element = next; element = next;
} }
// TODO(titzer): we need a handle scope only because of the macro assembler, // We need a handle scope only because of the macro assembler,
// which is only used in EnsureCodeForDeoptimizationEntry. // which is used in code patching in EnsureCodeForDeoptimizationEntry.
HandleScope scope(isolate); HandleScope scope(isolate);
// Now patch all the codes for deoptimization. // Now patch all the codes for deoptimization.
......
...@@ -6428,7 +6428,7 @@ class Script: public Struct { ...@@ -6428,7 +6428,7 @@ class Script: public Struct {
// [line_ends]: FixedArray of line ends positions. // [line_ends]: FixedArray of line ends positions.
DECL_ACCESSORS(line_ends, Object) DECL_ACCESSORS(line_ends, Object)
// [eval_from_shared]: for eval scripts the shared funcion info for the // [eval_from_shared]: for eval scripts the shared function info for the
// function from which eval was called. // function from which eval was called.
DECL_ACCESSORS(eval_from_shared, Object) DECL_ACCESSORS(eval_from_shared, Object)
......
...@@ -401,7 +401,6 @@ class Uint32BinopTester : public BinopTester<uint32_t, USE_RETURN_REGISTER> { ...@@ -401,7 +401,6 @@ class Uint32BinopTester : public BinopTester<uint32_t, USE_RETURN_REGISTER> {
// A helper class for testing code sequences that take two float parameters and // A helper class for testing code sequences that take two float parameters and
// return a float value. // return a float value.
// TODO(titzer): figure out how to return floats correctly on ia32.
class Float32BinopTester : public BinopTester<float, USE_RESULT_BUFFER> { class Float32BinopTester : public BinopTester<float, USE_RESULT_BUFFER> {
public: public:
explicit Float32BinopTester(RawMachineAssemblerTester<int32_t>* tester) explicit Float32BinopTester(RawMachineAssemblerTester<int32_t>* tester)
...@@ -411,7 +410,6 @@ class Float32BinopTester : public BinopTester<float, USE_RESULT_BUFFER> { ...@@ -411,7 +410,6 @@ class Float32BinopTester : public BinopTester<float, USE_RESULT_BUFFER> {
// A helper class for testing code sequences that take two double parameters and // A helper class for testing code sequences that take two double parameters and
// return a double value. // return a double value.
// TODO(titzer): figure out how to return doubles correctly on ia32.
class Float64BinopTester : public BinopTester<double, USE_RESULT_BUFFER> { class Float64BinopTester : public BinopTester<double, USE_RESULT_BUFFER> {
public: public:
explicit Float64BinopTester(RawMachineAssemblerTester<int32_t>* tester) explicit Float64BinopTester(RawMachineAssemblerTester<int32_t>* tester)
......
...@@ -129,7 +129,6 @@ TEST(ConstructorCall) { ...@@ -129,7 +129,6 @@ TEST(ConstructorCall) {
} }
// TODO(titzer): factor these out into test-runtime-calls.cc
TEST(RuntimeCallCPP2) { TEST(RuntimeCallCPP2) {
FLAG_allow_natives_syntax = true; FLAG_allow_natives_syntax = true;
FunctionTester T("(function(a,b) { return %NumberImul(a, b); })"); FunctionTester T("(function(a,b) { return %NumberImul(a, b); })");
......
...@@ -605,7 +605,7 @@ static const char* hot_deopt_no_frame_entry_test_source = ...@@ -605,7 +605,7 @@ static const char* hot_deopt_no_frame_entry_test_source =
// 2 2 (program) [-1] // 2 2 (program) [-1]
// 6 6 (garbage collector) [-1] // 6 6 (garbage collector) [-1]
// //
// The test checks no FP ranges are present in a deoptimized funcion. // The test checks no FP ranges are present in a deoptimized function.
// If 'foo' has no ranges the samples falling into the prologue will miss the // If 'foo' has no ranges the samples falling into the prologue will miss the
// 'start' function on the stack, so 'foo' will be attached to the (root). // 'start' function on the stack, so 'foo' will be attached to the (root).
TEST(HotDeoptNoFrameEntry) { TEST(HotDeoptNoFrameEntry) {
......
...@@ -7301,7 +7301,7 @@ static void DebugEventBreakWithOptimizedStack( ...@@ -7301,7 +7301,7 @@ static void DebugEventBreakWithOptimizedStack(
CHECK(argument_name->Equals(context, v8_str(isolate, "count")) CHECK(argument_name->Equals(context, v8_str(isolate, "count"))
.FromJust()); .FromJust());
// Get the value of the first argument in frame i. If the // Get the value of the first argument in frame i. If the
// funtion is optimized the value will be undefined, otherwise // function is optimized the value will be undefined, otherwise
// the value will be '1 - i'. // the value will be '1 - i'.
// //
// TODO(3141533): We should be able to get the real value for // TODO(3141533): We should be able to get the real value for
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment