Commit 53d67fe4 authored by Camillo Bruni's avatar Camillo Bruni Committed by Commit Bot

[tools] Show more entries in the ticks-processor

- lower the cutoff-threshold for bottom up graphs to 1%
- show all builtins/stubs/ics by default

R=jkummerow@chromium.org

Change-Id: I522173155b817ae20a37c40ecf411f2b55d82105
Reviewed-on: https://chromium-review.googlesource.com/452482Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43717}
parent 61a8954e
...@@ -33,7 +33,7 @@ Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0 excluded). ...@@ -33,7 +33,7 @@ Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0 excluded).
[Bottom up (heavy) profile]: [Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total Note: percentage shows a share of a particular caller in the total
amount of its parent calls. amount of its parent calls.
Callers occupying less than 2.0% are not shown. Callers occupying less than 1.0% are not shown.
ticks parent name ticks parent name
3 23.1% /lib32/libm-2.7.so 3 23.1% /lib32/libm-2.7.so
......
...@@ -23,7 +23,7 @@ Statistical profiling result from v8.log, (3 ticks, 0 unaccounted, 0 excluded). ...@@ -23,7 +23,7 @@ Statistical profiling result from v8.log, (3 ticks, 0 unaccounted, 0 excluded).
[Bottom up (heavy) profile]: [Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total Note: percentage shows a share of a particular caller in the total
amount of its parent calls. amount of its parent calls.
Callers occupying less than 2.0% are not shown. Callers occupying less than 1.0% are not shown.
ticks parent name ticks parent name
3 100.0% LazyCompile: DrawLine 3d-cube.js:17 3 100.0% LazyCompile: DrawLine 3d-cube.js:17
......
...@@ -22,6 +22,6 @@ Statistical profiling result from v8.log, (13 ticks, 0 unaccounted, 13 excluded) ...@@ -22,6 +22,6 @@ Statistical profiling result from v8.log, (13 ticks, 0 unaccounted, 13 excluded)
[Bottom up (heavy) profile]: [Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total Note: percentage shows a share of a particular caller in the total
amount of its parent calls. amount of its parent calls.
Callers occupying less than 2.0% are not shown. Callers occupying less than 1.0% are not shown.
ticks parent name ticks parent name
...@@ -32,7 +32,7 @@ Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0 excluded). ...@@ -32,7 +32,7 @@ Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0 excluded).
[Bottom up (heavy) profile]: [Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total Note: percentage shows a share of a particular caller in the total
amount of its parent calls. amount of its parent calls.
Callers occupying less than 2.0% are not shown. Callers occupying less than 1.0% are not shown.
ticks parent name ticks parent name
3 27.3% /lib32/libm-2.7.so 3 27.3% /lib32/libm-2.7.so
......
...@@ -35,7 +35,7 @@ Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0 excluded). ...@@ -35,7 +35,7 @@ Statistical profiling result from v8.log, (13 ticks, 2 unaccounted, 0 excluded).
[Bottom up (heavy) profile]: [Bottom up (heavy) profile]:
Note: percentage shows a share of a particular caller in the total Note: percentage shows a share of a particular caller in the total
amount of its parent calls. amount of its parent calls.
Callers occupying less than 2.0% are not shown. Callers occupying less than 1.0% are not shown.
ticks parent name ticks parent name
3 23.1% /lib32/libm-2.7.so 3 23.1% /lib32/libm-2.7.so
......
...@@ -322,8 +322,13 @@ CppEntriesProviderMock.prototype.parseVmSymbols = function( ...@@ -322,8 +322,13 @@ CppEntriesProviderMock.prototype.parseVmSymbols = function(
function PrintMonitor(outputOrFileName) { function PrintMonitor(outputOrFileName) {
var expectedOut = this.expectedOut = typeof outputOrFileName == 'string' ? this.expectedOut = outputOrFileName;
this.loadExpectedOutput(outputOrFileName) : outputOrFileName; this.outputFile = undefined;
if (typeof outputOrFileName == 'string') {
this.expectedOut = this.loadExpectedOutput(outputOrFileName)
this.outputFile = outputOrFileName;
}
var expectedOut = this.expectedOut;
var outputPos = 0; var outputPos = 0;
var diffs = this.diffs = []; var diffs = this.diffs = [];
var realOut = this.realOut = []; var realOut = this.realOut = [];
...@@ -361,6 +366,9 @@ PrintMonitor.prototype.finish = function() { ...@@ -361,6 +366,9 @@ PrintMonitor.prototype.finish = function() {
print("===== actual output: ====="); print("===== actual output: =====");
print(this.realOut.join('\n')); print(this.realOut.join('\n'));
print("===== expected output: ====="); print("===== expected output: =====");
if (this.outputFile) {
print("===== File: " + this.outputFile + " =====");
}
print(this.expectedOut.join('\n')); print(this.expectedOut.join('\n'));
assertEquals([], this.diffs); assertEquals([], this.diffs);
assertNull(this.unexpectedOut); assertNull(this.unexpectedOut);
......
...@@ -86,7 +86,7 @@ function start_process() { ...@@ -86,7 +86,7 @@ function start_process() {
stateFilter: null, stateFilter: null,
callGraphSize: 5, callGraphSize: 5,
ignoreUnknown: false, ignoreUnknown: false,
separateIc: false, separateIc: true,
targetRootFS: '', targetRootFS: '',
nm: 'nm' nm: 'nm'
}; };
......
...@@ -202,7 +202,7 @@ TickProcessor.CodeTypes = { ...@@ -202,7 +202,7 @@ TickProcessor.CodeTypes = {
// codeTypes_ map because there can be zillions of them. // codeTypes_ map because there can be zillions of them.
TickProcessor.CALL_PROFILE_CUTOFF_PCT = 2.0; TickProcessor.CALL_PROFILE_CUTOFF_PCT = 1.0;
TickProcessor.CALL_GRAPH_SIZE = 5; TickProcessor.CALL_GRAPH_SIZE = 5;
...@@ -855,7 +855,7 @@ ArgumentsProcessor.DEFAULTS = { ...@@ -855,7 +855,7 @@ ArgumentsProcessor.DEFAULTS = {
stateFilter: null, stateFilter: null,
callGraphSize: 5, callGraphSize: 5,
ignoreUnknown: false, ignoreUnknown: false,
separateIc: false, separateIc: true,
preprocessJson: null, preprocessJson: null,
targetRootFS: '', targetRootFS: '',
nm: 'nm', nm: 'nm',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment