Commit 527f5899 authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

[wasm] Do not expose OnFinishedUnit(s)

The method is only called from module-compiler.cc, hence we can call it
on {CompilationStateImpl} directly and do not need to expose it.

R=mstarzinger@chromium.org
CC=frgossen@google.com

Change-Id: I72dcd7b109cfdb0b3fd78be635c482289c69dd9e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587389Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61086}
parent c0720d28
......@@ -122,9 +122,6 @@ class CompilationState {
V8_EXPORT_PRIVATE bool baseline_compilation_finished() const;
V8_EXPORT_PRIVATE bool top_tier_compilation_finished() const;
void OnFinishedUnit(WasmCode*);
void OnFinishedUnits(Vector<WasmCode*>);
private:
friend class NativeModule;
friend class WasmCompilationUnit;
......
......@@ -338,7 +338,6 @@ class CompilationStateImpl {
std::unique_ptr<WasmCompilationUnit> GetNextCompilationUnit(
int task_id, CompileBaselineOnly baseline_only);
void OnFinishedUnit(WasmCode*);
void OnFinishedUnits(Vector<WasmCode*>);
void OnBackgroundTaskStopped(int task_id, const WasmFeatures& detected);
......@@ -497,14 +496,6 @@ bool CompilationState::top_tier_compilation_finished() const {
return Impl(this)->top_tier_compilation_finished();
}
void CompilationState::OnFinishedUnit(WasmCode* code) {
Impl(this)->OnFinishedUnit(code);
}
void CompilationState::OnFinishedUnits(Vector<WasmCode*> code_vector) {
Impl(this)->OnFinishedUnits(code_vector);
}
// static
std::unique_ptr<CompilationState> CompilationState::New(
const std::shared_ptr<NativeModule>& native_module,
......@@ -2036,10 +2027,6 @@ CompilationStateImpl::GetNextCompilationUnit(
return compilation_unit_queues_.GetNextUnit(task_id, baseline_only);
}
void CompilationStateImpl::OnFinishedUnit(WasmCode* code) {
OnFinishedUnits({&code, 1});
}
void CompilationStateImpl::OnFinishedUnits(Vector<WasmCode*> code_vector) {
base::MutexGuard guard(&callbacks_mutex_);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment