Commit 50ebabaf authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Weaken a DCHECK for coarse-grained unittest

R=nicohartmann@chromium.org

Change-Id: I55ef4e0713e0aa583ea01f1a86fee9cf0ef2c17a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184296
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67646}
parent 6204768b
......@@ -1249,7 +1249,10 @@ Type OperationTyper::StrictEqual(Type lhs, Type rhs) {
// Types are equal and are inhabited only by a single semantic value,
// which is not nan due to the earlier check.
DCHECK(lhs.Is(rhs));
DCHECK(lhs.Is(Type::NonInternal()) || lhs.Is(Type::Hole()));
// TODO(neis): The last condition in this DCHECK is due the unittest
// throwing arbitrary types at the typer. This is not easy to fix.
DCHECK(lhs.Is(Type::NonInternal()) || lhs.Is(Type::Hole()) ||
FLAG_testing_d8_test_runner);
return singleton_true();
}
if ((lhs.Is(Type::Unique()) || rhs.Is(Type::Unique())) && !lhs.Maybe(rhs)) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment