Commit 4ffdce65 authored by machenbach's avatar machenbach Committed by Commit bot

[Interpreter] Prepare switching to new ignition testing variant.

This adds a new ignition_turbofan testing variant that'll
allow switching turbofan off in the other ignition variant.

The switch will happen in a follow up after reconfiguring
the bots.

BUG=v8:4280
LOG=N

Review URL: https://codereview.chromium.org/1922623003

Cr-Commit-Position: refs/heads/master@{#35790}
parent 5796ae9d
......@@ -492,7 +492,7 @@
}], # 'arch == ppc64 and simulator_run == True'
##############################################################################
['ignition == True', {
['ignition or ignition_turbofan', {
# TODO(rmcilroy,4680): Check failed: !function->shared()->is_compiled() || function->IsOptimized().
'test-heap/TestCodeFlushingPreAged': [FAIL],
'test-heap/TestCodeFlushingIncrementalScavenge': [FAIL],
......@@ -561,6 +561,6 @@
# BUG(4751). Flaky with ignition and tsan.
'test-cpu-profiler/JsNativeJsSample': [PASS, ['tsan', SKIP]],
}], # ignition == True
}], # ignition or ignition_turbofan
]
......@@ -750,7 +750,7 @@
}], # 'arch == ppc and simulator_run == True'
##############################################################################
['ignition == True', {
['ignition or ignition_turbofan', {
# TODO(yangguo,4690): flaky failures on the bots.
'debug-stepin-builtin-callback-opt': [SKIP],
......@@ -797,25 +797,25 @@
'wasm/asm-wasm-f32': [PASS, ['arch in [arm64]', SKIP]],
'wasm/asm-wasm-f64': [PASS, ['arch in [arm64]', SKIP]],
}], # ignition == True
}], # ignition or ignition_turbofan
['ignition == True and arch == arm64', {
['(ignition or ignition_turbofan) and arch == arm64', {
# TODO(rmcilroy,4680): Arm64 specific timeouts.
'asm/construct-double': [SKIP],
'compiler/osr-one': [SKIP],
'compiler/osr-two': [SKIP],
'wasm/asm-wasm-i32': [SKIP],
'wasm/asm-wasm-u32': [SKIP],
}], # ignition == True and arch == arm64
}], # (ignition or ignition_turbofan) and arch == arm64
['ignition == True and arch == arm', {
['(ignition or ignition_turbofan) and arch == arm', {
# TODO(rmcilroy,4680): Arm specific timeouts.
'compiler/osr-one': [SKIP],
'compiler/osr-two': [SKIP],
'regress/regress-1257': [SKIP],
}], # ignition == True and arch == arm
}], # (ignition or ignition_turbofan) and arch == arm
['ignition == True and msan', {
['(ignition or ignition_turbofan) and msan', {
# TODO(mythria,4680): All of these tests have large loops and hence slow
# and timeout.
'compiler/osr-big': [SKIP],
......@@ -826,21 +826,21 @@
'try': [SKIP],
# Too slow for interpreter and msan.
'es6/tail-call-megatest*': [SKIP],
}], # ignition == True and msan
}], # (ignition or ignition_turbofan) and msan
['ignition == True and gc_stress == True', {
['(ignition or ignition_turbofan) and gc_stress == True', {
# TODO(oth,4680): failures from the bots.
'es6/debug-step-destructuring-bind': [SKIP],
'es6/debug-stepin-collections-foreach': [SKIP],
'ignition/elided-instruction': [SKIP],
'regress/regress-269': [SKIP],
}], # ignition == True and gc_stress == True
}], # (ignition or ignition_turbofan) and gc_stress == True
['ignition == False', {
['ignition == False and ignition_turbofan == False', {
# Debugger test cases that pass with full-codegen, but not ignition.
# These differences between full-codegen and ignition are deliberate.
'ignition/elided-instruction': [FAIL],
}], # ignition == False
}], # ignition == False and ignition_turbofan == False
##############################################################################
['gcov_coverage', {
......
......@@ -101,11 +101,11 @@
}], # 'gc_stress == True and mode == debug'
##############################################################################
['ignition == True and msan', {
['(ignition or ignition_turbofan) and msan', {
# TODO(mythria,4680): Too slow and timeout on ignition.
'dfg-double-vote-fuzz': [SKIP],
'dfg-int-overflow-in-loop': [SKIP],
}], # ignition == True and msan
}], # (ignition or ignition_turbofan) and msan
##############################################################################
['gcov_coverage', {
......
......@@ -399,6 +399,7 @@ def Execute(arch, mode, args, options, suites, workspace):
"gc_stress": False,
"gcov_coverage": False,
"ignition": False,
"ignition_turbofan": False,
"isolates": options.isolates,
"mode": mode,
"no_i18n": False,
......
......@@ -255,6 +255,9 @@ def BuildOptions():
default="")
result.add_option("--ignition", help="Skip tests which don't run in ignition",
default=False, action="store_true")
result.add_option("--ignition-turbofan",
help="Skip tests which don't run in ignition_turbofan",
default=False, action="store_true")
result.add_option("--isolates", help="Whether to test isolates",
default=False, action="store_true")
result.add_option("-j", help="The number of parallel tasks to run",
......@@ -720,6 +723,7 @@ def Execute(arch, mode, args, options, suites):
"gc_stress": options.gc_stress,
"gcov_coverage": options.gcov_coverage,
"ignition": options.ignition,
"ignition_turbofan": options.ignition_turbofan,
"isolates": options.isolates,
"mode": MODES[mode]["status_mode"],
"no_i18n": options.no_i18n,
......
......@@ -42,6 +42,7 @@ ALL_VARIANT_FLAGS = {
"turbofan_opt": [["--turbo", "--always-opt"]],
"nocrankshaft": [["--nocrankshaft"]],
"ignition": [["--ignition", "--turbo"]],
"ignition_turbofan": [["--ignition", "--turbo"]],
"preparser": [["--min-preparse-length=0"]],
}
......@@ -52,11 +53,13 @@ FAST_VARIANT_FLAGS = {
"turbofan": [["--turbo"]],
"nocrankshaft": [["--nocrankshaft"]],
"ignition": [["--ignition", "--turbo"]],
"ignition_turbofan": [["--ignition", "--turbo"]],
"preparser": [["--min-preparse-length=0"]],
}
ALL_VARIANTS = set(["default", "stress", "turbofan", "turbofan_opt",
"nocrankshaft", "ignition", "preparser"])
"nocrankshaft", "ignition", "ignition_turbofan",
"preparser"])
FAST_VARIANTS = set(["default", "turbofan"])
STANDARD_VARIANT = set(["default"])
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment