Commit 4fe89e59 authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[build] Add common_test_headers dep to wasm_api_tests

Fixes gn check error due to include of
test/common/wasm/wasm-macro-gen.h. Also changes common_test_headers dep
from v8_for_testing to v8_internal_headers, since otherwise on windows
the wasm_api_tests binary ends up depending on wee8 and
libv8_for_testing which define many of the same symbols.

Bug: v8:7330
Change-Id: Ib03b860668146f21456729a3d2c5e0d75d8c17d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2729335
Auto-Submit: Dan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73150}
parent e4f63bae
......@@ -146,7 +146,7 @@ v8_header_set("common_test_headers") {
configs = []
public_deps = [
"../:v8_for_testing",
"../:v8_internal_headers",
"../:v8_libbase",
]
......
......@@ -8,6 +8,7 @@ v8_executable("wasm_api_tests") {
testonly = true
deps = [
"../:common_test_headers",
"../..:v8_internal_headers",
"../..:v8_maybe_icu",
"../..:wee8",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment