Commit 4fd8c327 authored by yurys's avatar yurys Committed by Commit bot

Tell MSAN that profiler doesn't expect sp to point at initialized memory

BUG=v8:4444,v8:4151
LOG=N

Review URL: https://codereview.chromium.org/1371253002

Cr-Commit-Position: refs/heads/master@{#30996}
parent 3bb01743
...@@ -682,6 +682,9 @@ DISABLE_ASAN void TickSample::Init(Isolate* isolate, ...@@ -682,6 +682,9 @@ DISABLE_ASAN void TickSample::Init(Isolate* isolate,
external_callback = scope->callback(); external_callback = scope->callback();
has_external_callback = true; has_external_callback = true;
} else { } else {
// sp register may point at an arbitrary place in memory, make
// sure MSAN doesn't complain about it.
MSAN_MEMORY_IS_INITIALIZED(regs.sp, sizeof(Address));
// Sample potential return address value for frameless invocation of // Sample potential return address value for frameless invocation of
// stubs (we'll figure out later, if this value makes sense). // stubs (we'll figure out later, if this value makes sense).
tos = Memory::Address_at(reinterpret_cast<Address>(regs.sp)); tos = Memory::Address_at(reinterpret_cast<Address>(regs.sp));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment