Commit 4f941eb4 authored by Dominik Inführ's avatar Dominik Inführ Committed by Commit Bot

[heap] Disable --stress-concurrent-allocation for some tests

Two tests already test concurrent allocation. Another one measures
memory, so non-deterministic allocation would lead to higher memory
usage than anticipated.

Bug: v8:10315
Change-Id: If994233c87ea04076b850ffdf024f7783653e9db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2352781Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69383}
parent 34b65260
...@@ -74,6 +74,7 @@ UNINITIALIZED_TEST(ConcurrentAllocationInOldSpace) { ...@@ -74,6 +74,7 @@ UNINITIALIZED_TEST(ConcurrentAllocationInOldSpace) {
FLAG_max_old_space_size = 32; FLAG_max_old_space_size = 32;
FLAG_concurrent_allocation = true; FLAG_concurrent_allocation = true;
FLAG_local_heaps = true; FLAG_local_heaps = true;
FLAG_stress_concurrent_allocation = false;
v8::Isolate::CreateParams create_params; v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator(); create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
...@@ -135,6 +136,7 @@ UNINITIALIZED_TEST(ConcurrentAllocationInLargeSpace) { ...@@ -135,6 +136,7 @@ UNINITIALIZED_TEST(ConcurrentAllocationInLargeSpace) {
FLAG_max_old_space_size = 32; FLAG_max_old_space_size = 32;
FLAG_concurrent_allocation = true; FLAG_concurrent_allocation = true;
FLAG_local_heaps = true; FLAG_local_heaps = true;
FLAG_stress_concurrent_allocation = false;
v8::Isolate::CreateParams create_params; v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator(); create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
......
...@@ -377,8 +377,9 @@ intptr_t ShortLivingIsolate() { ...@@ -377,8 +377,9 @@ intptr_t ShortLivingIsolate() {
return MemoryInUse(); return MemoryInUse();
} }
UNINITIALIZED_TEST(RegressJoinThreadsOnIsolateDeinit) {
TEST(RegressJoinThreadsOnIsolateDeinit) { // Memory is measured, do not allocate in background thread.
FLAG_stress_concurrent_allocation = false;
intptr_t size_limit = ShortLivingIsolate() * 2; intptr_t size_limit = ShortLivingIsolate() * 2;
for (int i = 0; i < 10; i++) { for (int i = 0; i < 10; i++) {
CHECK_GT(size_limit, ShortLivingIsolate()); CHECK_GT(size_limit, ShortLivingIsolate());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment