Commit 4f798f90 authored by kozyatinskiy's avatar kozyatinskiy Committed by Commit bot

[inspector] revert fallThrough support for async methods

We can't use "this" after calling agent code since agent code can destroy dispatcher.

BUG=chromium:668358
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2526183002
Cr-Commit-Position: refs/heads/master@{#41247}
parent f277da2a
...@@ -14,3 +14,4 @@ description. ...@@ -14,3 +14,4 @@ description.
Local modifications: Local modifications:
- This only includes the lib/ and templates/ directories, scripts, build - This only includes the lib/ and templates/ directories, scripts, build
and the LICENSE files. and the LICENSE files.
- FallbackThrough support is removed for async methods.
...@@ -367,7 +367,7 @@ DispatchResponse::Status DispatcherImpl::{{command.name}}(int callId, std::uniqu ...@@ -367,7 +367,7 @@ DispatchResponse::Status DispatcherImpl::{{command.name}}(int callId, std::uniqu
{%- endfor -%} {%- endfor -%}
{%- if command.parameters -%}, {% endif -%} {%- if command.parameters -%}, {% endif -%}
std::move(callback)); std::move(callback));
return lastCallbackFallThrough() ? DispatchResponse::kFallThrough : DispatchResponse::kAsync; return DispatchResponse::kAsync;
{% endif %} {% endif %}
} }
{% endfor %} {% endfor %}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment