Commit 4eedff25 authored by Andreas Haas's avatar Andreas Haas Committed by Commit Bot

Revert "[wasm] Remove V8.LiftoffCompileMicroSeconds counter"

This reverts commit 397ddfee.

Reason for revert: The counter is actually used in benchmarks, e.g. https://ci.chromium.org/p/v8-internal/builders/ci/v8_linux64_perf/7593

Original change's description:
> [wasm] Remove V8.LiftoffCompileMicroSeconds counter
>
> The counter gets created but isn't used anywhere.
>
> R=​clemensb@chromium.org
>
> Bug: v8:10933
> Change-Id: I480e601f8118475a3ce750ba97fdae6780342d49
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2497166
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Commit-Queue: Andreas Haas <ahaas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70756}

TBR=ahaas@chromium.org,clemensb@chromium.org

Change-Id: I15679baa338e317c54fafd98f547db006b276bae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10933
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498696Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70760}
parent 813a95d9
......@@ -184,6 +184,8 @@ namespace internal {
1000000, MICROSECOND) \
HT(wasm_compile_wasm_function_time, V8.WasmCompileFunctionMicroSeconds.wasm, \
1000000, MICROSECOND) \
HT(liftoff_compile_time, V8.LiftoffCompileMicroSeconds, 10000000, \
MICROSECOND) \
HT(wasm_instantiate_wasm_module_time, \
V8.WasmInstantiateModuleMicroSeconds.wasm, 10000000, MICROSECOND) \
HT(wasm_instantiate_asm_module_time, \
......
......@@ -4120,6 +4120,10 @@ WasmCompilationResult ExecuteLiftoffCompilation(
Zone zone(allocator, "LiftoffCompilationZone");
auto call_descriptor = compiler::GetWasmCallDescriptor(&zone, func_body.sig);
base::Optional<TimedHistogramScope> liftoff_compile_time_scope;
if (counters) {
liftoff_compile_time_scope.emplace(counters->liftoff_compile_time());
}
size_t code_size_estimate =
WasmCodeManager::EstimateLiftoffCodeSize(func_body_size);
// Allocate the initial buffer a bit bigger to avoid reallocation during code
......@@ -4138,6 +4142,7 @@ WasmCompilationResult ExecuteLiftoffCompilation(
debug_sidetable_builder.get(), for_debugging, func_index, breakpoints,
dead_breakpoint);
decoder.Decode();
liftoff_compile_time_scope.reset();
LiftoffCompiler* compiler = &decoder.interface();
if (decoder.failed()) {
compiler->OnFirstError(&decoder);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment