Commit 4e56a93d authored by Deepti Gandluri's avatar Deepti Gandluri Committed by Commit Bot

[x64] Minor cleanup to use register variables when declared

Bug:V8:11074

Change-Id: I843fcc2b48aa9303396c8d192d15c75e2f763d2d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2657971
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72440}
parent 45b99aaa
...@@ -2652,11 +2652,11 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction( ...@@ -2652,11 +2652,11 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
if (dst == src) { if (dst == src) {
__ Pcmpeqd(kScratchDoubleReg, kScratchDoubleReg); __ Pcmpeqd(kScratchDoubleReg, kScratchDoubleReg);
__ Psrld(kScratchDoubleReg, byte{1}); __ Psrld(kScratchDoubleReg, byte{1});
__ Andps(i.OutputSimd128Register(), kScratchDoubleReg); __ Andps(dst, kScratchDoubleReg);
} else { } else {
__ Pcmpeqd(dst, dst); __ Pcmpeqd(dst, dst);
__ Psrld(dst, byte{1}); __ Psrld(dst, byte{1});
__ Andps(dst, i.InputSimd128Register(0)); __ Andps(dst, src);
} }
break; break;
} }
...@@ -2666,11 +2666,11 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction( ...@@ -2666,11 +2666,11 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
if (dst == src) { if (dst == src) {
__ Pcmpeqd(kScratchDoubleReg, kScratchDoubleReg); __ Pcmpeqd(kScratchDoubleReg, kScratchDoubleReg);
__ Pslld(kScratchDoubleReg, byte{31}); __ Pslld(kScratchDoubleReg, byte{31});
__ Xorps(i.OutputSimd128Register(), kScratchDoubleReg); __ Xorps(dst, kScratchDoubleReg);
} else { } else {
__ Pcmpeqd(dst, dst); __ Pcmpeqd(dst, dst);
__ Pslld(dst, byte{31}); __ Pslld(dst, byte{31});
__ Xorps(dst, i.InputSimd128Register(0)); __ Xorps(dst, src);
} }
break; break;
} }
...@@ -3291,9 +3291,10 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction( ...@@ -3291,9 +3291,10 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
} }
case kX64I16x8Ne: { case kX64I16x8Ne: {
XMMRegister tmp = i.TempSimd128Register(0); XMMRegister tmp = i.TempSimd128Register(0);
__ Pcmpeqw(i.OutputSimd128Register(), i.InputSimd128Register(1)); XMMRegister dst = i.OutputSimd128Register();
__ Pcmpeqw(dst, i.InputSimd128Register(1));
__ Pcmpeqw(tmp, tmp); __ Pcmpeqw(tmp, tmp);
__ Pxor(i.OutputSimd128Register(), tmp); __ Pxor(dst, tmp);
break; break;
} }
case kX64I16x8GtS: { case kX64I16x8GtS: {
...@@ -3624,9 +3625,10 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction( ...@@ -3624,9 +3625,10 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
} }
case kX64I8x16Ne: { case kX64I8x16Ne: {
XMMRegister tmp = i.TempSimd128Register(0); XMMRegister tmp = i.TempSimd128Register(0);
__ Pcmpeqb(i.OutputSimd128Register(), i.InputSimd128Register(1)); XMMRegister dst = i.OutputSimd128Register();
__ Pcmpeqb(dst, i.InputSimd128Register(1));
__ Pcmpeqb(tmp, tmp); __ Pcmpeqb(tmp, tmp);
__ Pxor(i.OutputSimd128Register(), tmp); __ Pxor(dst, tmp);
break; break;
} }
case kX64I8x16GtS: { case kX64I8x16GtS: {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment