Commit 4e1fadf4 authored by Ulan Degenbaev's avatar Ulan Degenbaev Committed by V8 LUCI CQ

Update TODOs to use bug ids

This also removes small TODOs that are not worth tracking in a bug

Change-Id: If61acd1239ac90a908327694b280846b1f676c25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909859Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74698}
parent 1186fc50
...@@ -11152,8 +11152,8 @@ void CodeStubAssembler::TrapAllocationMemento(TNode<JSObject> object, ...@@ -11152,8 +11152,8 @@ void CodeStubAssembler::TrapAllocationMemento(TNode<JSObject> object,
IntPtrConstant(MemoryChunk::kIsInYoungGenerationMask)), IntPtrConstant(MemoryChunk::kIsInYoungGenerationMask)),
IntPtrConstant(0)), IntPtrConstant(0)),
&no_memento_found); &no_memento_found);
// TODO(ulan): Support allocation memento for a large object by allocating // TODO(v8:11799): Support allocation memento for a large object by
// additional word for the memento after the large object. // allocating additional word for the memento after the large object.
GotoIf(WordNotEqual(WordAnd(page_flags, GotoIf(WordNotEqual(WordAnd(page_flags,
IntPtrConstant(MemoryChunk::kIsLargePageMask)), IntPtrConstant(MemoryChunk::kIsLargePageMask)),
IntPtrConstant(0)), IntPtrConstant(0)),
......
...@@ -8,9 +8,9 @@ namespace v8 { ...@@ -8,9 +8,9 @@ namespace v8 {
namespace internal { namespace internal {
double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) { double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) {
// TODO(ulan): This clobbers only subset of registers depending on compiler, // TODO(v8:11798): This clobbers only subset of registers depending on
// Rewrite this in assembly to really clobber all registers. // compiler, Rewrite this in assembly to really clobber all registers. GCC for
// GCC for ia32 uses the FPU and does not touch XMM registers. // ia32 uses the FPU and does not touch XMM registers.
return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04; return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04;
} }
......
...@@ -4451,8 +4451,8 @@ void Heap::VerifyRememberedSetFor(HeapObject object) { ...@@ -4451,8 +4451,8 @@ void Heap::VerifyRememberedSetFor(HeapObject object) {
&this->ephemeron_remembered_set_); &this->ephemeron_remembered_set_);
object.IterateBody(&visitor); object.IterateBody(&visitor);
} }
// TODO(ulan): Add old to old slot set verification once all weak objects // TODO(v8:11797): Add old to old slot set verification once all weak objects
// have their own instance types and slots are recorded for all weal fields. // have their own instance types and slots are recorded for all weak fields.
} }
#endif #endif
......
...@@ -2429,7 +2429,6 @@ void MarkCompactCollector::TrimDescriptorArray(Map map, ...@@ -2429,7 +2429,6 @@ void MarkCompactCollector::TrimDescriptorArray(Map map,
DCHECK(descriptors == ReadOnlyRoots(heap_).empty_descriptor_array()); DCHECK(descriptors == ReadOnlyRoots(heap_).empty_descriptor_array());
return; return;
} }
// TODO(ulan): Trim only if slack is greater than some percentage threshold.
int to_trim = int to_trim =
descriptors.number_of_all_descriptors() - number_of_own_descriptors; descriptors.number_of_all_descriptors() - number_of_own_descriptors;
if (to_trim > 0) { if (to_trim > 0) {
......
...@@ -370,7 +370,7 @@ void ReadOnlySpace::RepairFreeSpacesAfterDeserialization() { ...@@ -370,7 +370,7 @@ void ReadOnlySpace::RepairFreeSpacesAfterDeserialization() {
void ReadOnlySpace::ClearStringPaddingIfNeeded() { void ReadOnlySpace::ClearStringPaddingIfNeeded() {
if (V8_ENABLE_THIRD_PARTY_HEAP_BOOL) { if (V8_ENABLE_THIRD_PARTY_HEAP_BOOL) {
// TODO(ulan): Revisit this once third-party heap supports iteration. // TODO(v8:11641): Revisit this once third-party heap supports iteration.
return; return;
} }
if (is_string_padding_cleared_) return; if (is_string_padding_cleared_) return;
......
...@@ -84,7 +84,6 @@ class RememberedSetOperations { ...@@ -84,7 +84,6 @@ class RememberedSetOperations {
} }
}; };
// TODO(ulan): Investigate performance of de-templatizing this class.
template <RememberedSetType type> template <RememberedSetType type>
class RememberedSet : public AllStatic { class RememberedSet : public AllStatic {
public: public:
......
...@@ -892,7 +892,6 @@ Handle<Map> CreateNonConstructorMap(Isolate* isolate, Handle<Map> source_map, ...@@ -892,7 +892,6 @@ Handle<Map> CreateNonConstructorMap(Isolate* isolate, Handle<Map> source_map,
// inital map even when the prototype property is not required). // inital map even when the prototype property is not required).
if (!map->has_prototype_slot()) { if (!map->has_prototype_slot()) {
// Re-set the unused property fields after changing the instance size. // Re-set the unused property fields after changing the instance size.
// TODO(ulan): Do not change instance size after map creation.
int unused_property_fields = map->UnusedPropertyFields(); int unused_property_fields = map->UnusedPropertyFields();
map->set_instance_size(map->instance_size() + kTaggedSize); map->set_instance_size(map->instance_size() + kTaggedSize);
// The prototype slot shifts the in-object properties area by one slot. // The prototype slot shifts the in-object properties area by one slot.
......
...@@ -91,7 +91,6 @@ class RootVisitor { ...@@ -91,7 +91,6 @@ class RootVisitor {
// Intended for serialization/deserialization checking: insert, or // Intended for serialization/deserialization checking: insert, or
// check for the presence of, a tag at this position in the stream. // check for the presence of, a tag at this position in the stream.
// Also used for marking up GC roots in heap snapshots. // Also used for marking up GC roots in heap snapshots.
// TODO(ulan): Remove this.
virtual void Synchronize(VisitorSynchronization::SyncTag tag) {} virtual void Synchronize(VisitorSynchronization::SyncTag tag) {}
static const char* RootName(Root root); static const char* RootName(Root root);
......
...@@ -1596,7 +1596,7 @@ bool V8HeapExplorer::IterateAndExtractReferences( ...@@ -1596,7 +1596,7 @@ bool V8HeapExplorer::IterateAndExtractReferences(
RootsReferencesExtractor extractor(this); RootsReferencesExtractor extractor(this);
ReadOnlyRoots(heap_).Iterate(&extractor); ReadOnlyRoots(heap_).Iterate(&extractor);
heap_->IterateRoots(&extractor, base::EnumSet<SkipRoot>{SkipRoot::kWeak}); heap_->IterateRoots(&extractor, base::EnumSet<SkipRoot>{SkipRoot::kWeak});
// TODO(ulan): The heap snapshot generator incorrectly considers the weak // TODO(v8:11800): The heap snapshot generator incorrectly considers the weak
// string tables as strong retainers. Move IterateWeakRoots after // string tables as strong retainers. Move IterateWeakRoots after
// SetVisitingWeakRoots. // SetVisitingWeakRoots.
heap_->IterateWeakRoots(&extractor, {}); heap_->IterateWeakRoots(&extractor, {});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment