Skip to content

V
V8
Commit 4cf30172 authored by Frank Tang's avatar Frank Tang Committed by V8 LUCI CQ
Browse files
Options

[Temporal] Add PlainYearMonth.from 

Also Add AOs: ToTemporalYearMonth, YearMonthFromFields, ParseTemporalYearMonthString

Spec Text:
https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.from
https://tc39.es/proposal-temporal/#sec-temporal-totemporalyearmonth
https://tc39.es/proposal-temporal/#sec-temporal-parsetemporalyearmonthstring
https://tc39.es/proposal-temporal/#sec-temporal-yearmonthfromfields

Bug: v8:11544
Change-Id: I04b30a4159142a996c765c542f19e66bee593e4e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3538666Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80683}
parent 9473a5e9
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 183 additions and 53 deletions
src/builtins/builtins-temporal.cc
View file @ 4cf30172
......@@ -200,8 +200,6 @@ TO_BE_IMPLEMENTED(TemporalInstantPrototypeToZonedDateTime)
TO_BE_IMPLEMENTED(TemporalInstantPrototypeToZonedDateTimeISO)
/* Temporal.PlainYearMonth */
/* Temporal #sec-temporal.plainyearmonth.from */
TO_BE_IMPLEMENTED(TemporalPlainYearMonthFrom)
/* Temporal #sec-temporal.plainyearmonth.compare */
TO_BE_IMPLEMENTED(TemporalPlainYearMonthCompare)
/* Temporal #sec-temporal.plainyearmonth.prototype.with */
......@@ -525,6 +523,7 @@ TEMPORAL_GET_BY_INVOKE_CALENDAR_METHOD(PlainYearMonth, DaysInMonth, daysInMonth)
TEMPORAL_GET_BY_INVOKE_CALENDAR_METHOD(PlainYearMonth, MonthsInYear,
monthsInYear)
TEMPORAL_GET_BY_INVOKE_CALENDAR_METHOD(PlainYearMonth, InLeapYear, inLeapYear)
TEMPORAL_METHOD2(PlainYearMonth, From)
TEMPORAL_PROTOTYPE_METHOD0(PlainYearMonth, GetISOFields, getISOFields)
TEMPORAL_VALUE_OF(PlainYearMonth)
TEMPORAL_PROTOTYPE_METHOD2(PlainYearMonth, ToLocaleString, toLocaleString)
......
src/objects/js-temporal-objects.cc
View file @ 4cf30172
This diff is collapsed.
src/objects/js-temporal-objects.h
View file @ 4cf30172
......@@ -443,6 +443,10 @@ class JSTemporalPlainYearMonth
Handle<Object> iso_month, Handle<Object> calendar_like,
Handle<Object> reference_iso_day);
// #sec-temporal.plainyearmonth.from
V8_WARN_UNUSED_RESULT static MaybeHandle<JSTemporalPlainYearMonth> From(
Isolate* isolate, Handle<Object> item, Handle<Object> options);
// #sec-temporal.plainyearmonth.prototype.getisofields
V8_WARN_UNUSED_RESULT static MaybeHandle<JSReceiver> GetISOFields(
Isolate* isolate, Handle<JSTemporalPlainYearMonth> year_month);
......
test/test262/test262.status
View file @ 4cf30172
......@@ -406,13 +406,7 @@
'built-ins/Temporal/Duration/prototype/with/negative-infinity-throws-rangeerror': [FAIL],
'built-ins/Temporal/Duration/prototype/with/non-integer-throws-rangeerror': [FAIL],
'built-ins/Temporal/Duration/prototype/with/order-of-operations': [FAIL],
'built-ins/Temporal/Calendar/prototype/dateUntil/argument-plaindatetime': [FAIL],
'built-ins/Temporal/Calendar/prototype/daysInYear/basic': [FAIL],
'built-ins/Temporal/Calendar/prototype/month/basic': [FAIL],
'built-ins/Temporal/Calendar/prototype/monthCode/basic': [FAIL],
'built-ins/Temporal/Calendar/prototype/year/basic': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-string-with-utc-designator': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-non-integer': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/argument-zoneddatetime-timezone-getoffsetnanosecondsfor-not-callable': [FAIL],
......@@ -424,7 +418,6 @@
'built-ins/Temporal/Calendar/prototype/weekOfYear/calendar-temporal-object': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/cross-year': [FAIL],
'built-ins/Temporal/Calendar/prototype/weekOfYear/infinity-throws-rangeerror': [FAIL],
'built-ins/Temporal/Duration/compare/argument-string-negative-fractional-units': [FAIL],
'built-ins/Temporal/Duration/compare/calendar-dateadd-called-with-plaindate-instance': [FAIL],
'built-ins/Temporal/Duration/compare/options-undefined': [FAIL],
......@@ -1305,18 +1298,7 @@
'built-ins/Temporal/PlainYearMonth/compare/calendar-yearmonthfromfields-called-with-options-undefined': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/infinity-throws-rangeerror': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/use-internal-slots': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-string': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-string-with-utc-designator': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/calendar-fields-iterable': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/calendar-temporal-object': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/calendar-yearmonthfromfields-called-with-options-undefined': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/infinity-throws-rangeerror': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/options-undefined': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/order-of-operations': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/overflow-invalid-string': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/overflow-undefined': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/overflow-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/subclassing-ignored': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/add/argument-not-object': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/add/argument-string': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/add/argument-string-negative-fractional-units': [FAIL],
......@@ -1802,7 +1784,6 @@
'intl402/Temporal/PlainTime/prototype/toPlainDateTime/infinity-throws-rangeerror': [FAIL],
'intl402/Temporal/PlainTime/prototype/toZonedDateTime/plaindate-infinity-throws-rangeerror': [FAIL],
'intl402/Temporal/PlainYearMonth/compare/infinity-throws-rangeerror': [FAIL],
'intl402/Temporal/PlainYearMonth/from/infinity-throws-rangeerror': [FAIL],
'intl402/Temporal/PlainYearMonth/prototype/equals/infinity-throws-rangeerror': [FAIL],
'intl402/Temporal/PlainYearMonth/prototype/since/infinity-throws-rangeerror': [FAIL],
'intl402/Temporal/PlainYearMonth/prototype/toLocaleString/locales-undefined': [FAIL],
......@@ -2043,16 +2024,6 @@
'built-ins/Temporal/PlainYearMonth/compare/compare-calendar': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/compare-reference-day': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/year-zero': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-object': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-plaindate': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-plainyearmonth': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-string-invalid': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-string-trailing-junk': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/limits': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/options-invalid': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/overflow-constrain': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/overflow-reject': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/year-zero': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/add/argument-duration-object': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/add/argument-lower-units': [FAIL],
......@@ -2102,7 +2073,6 @@
'built-ins/Temporal/PlainYearMonth/prototype/until/roundingmode-halfExpand': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/until/roundingmode-trunc': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/until/year-zero': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/valueOf/basic': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/with/argument-calendar-field': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/with/argument-missing-fields': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/with/argument-timezone-field': [FAIL],
......@@ -2205,7 +2175,6 @@
'built-ins/Temporal/PlainDateTime/prototype/with/timezone-throws': [FAIL],
'built-ins/Temporal/PlainTime/prototype/toPlainDateTime/argument-string-invalid': [FAIL],
'built-ins/Temporal/PlainTime/prototype/toZonedDateTime/argument-string-invalid': [FAIL],
'built-ins/Temporal/PlainYearMonth/calendar-always': [FAIL],
'built-ins/Temporal/ZonedDateTime/prototype/withPlainDate/argument-string-invalid': [FAIL],
'built-ins/Temporal/Duration/compare/options-wrong-type': [FAIL],
......@@ -2323,7 +2292,6 @@
'built-ins/Temporal/PlainTime/prototype/toString/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainTime/prototype/until/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainTime/prototype/with/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/add/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/since/options-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/subtract/options-wrong-type': [FAIL],
......@@ -2500,8 +2468,6 @@
'built-ins/Temporal/PlainYearMonth/compare/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/compare/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-propertybag-calendar-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/from/argument-wrong-type': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/equals/argument-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-number': [FAIL],
'built-ins/Temporal/PlainYearMonth/prototype/equals/argument-propertybag-calendar-wrong-type': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment