Commit 4b853c0e authored by Sathya Gunasekaran's avatar Sathya Gunasekaran Committed by V8 LUCI CQ

Revert "[compiler] Skip IsPendingAllocation check in Ref construction"

This reverts commit 03fcd892.

Reason for revert: breaks linux64 https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64/42874/overview

Original change's description:
> [compiler] Skip IsPendingAllocation check in Ref construction
>
> This temporarily reverts the key part of
> https://chromium-review.googlesource.com/c/v8/v8/+/2886861
> in order to unblock the roll.
>
> Bug: v8:7790, chromium:1209798
> Change-Id: I10a02bdb2f1a0e0a2b1238481dc39a1d975ee5b2
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2896983
> Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
> Commit-Queue: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#74611}

Bug: v8:7790
Bug: chromium:1209798
Change-Id: I79fae981acb3f2ddfc1d7d9a49a73d1741d19e71
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2901984
Auto-Submit: Sathya Gunasekaran  <gsathya@chromium.org>
Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74615}
parent 69a82842
...@@ -2775,6 +2775,12 @@ ObjectData* JSHeapBroker::TryGetOrCreateData(Handle<Object> object, ...@@ -2775,6 +2775,12 @@ ObjectData* JSHeapBroker::TryGetOrCreateData(Handle<Object> object,
DCHECK(!object->IsSmi()); DCHECK(!object->IsSmi());
const bool crash_on_error = (flags & kCrashOnError) != 0; const bool crash_on_error = (flags & kCrashOnError) != 0;
if ((flags & kAssumeMemoryFence) == 0 &&
ObjectMayBeUninitialized(HeapObject::cast(*object))) {
TRACE_BROKER_MISSING(this, "Object may be uninitialized " << *object);
CHECK_WITH_MSG(!crash_on_error, "Ref construction failed");
return nullptr;
}
if (IsReadOnlyHeapObjectForCompiler(HeapObject::cast(*object))) { if (IsReadOnlyHeapObjectForCompiler(HeapObject::cast(*object))) {
entry = refs_->LookupOrInsert(object.address()); entry = refs_->LookupOrInsert(object.address());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment