Skip to content

V
V8
Commit 4a8d1e79 authored by Daniel Ehrenberg's avatar Daniel Ehrenberg Committed by Commit Bot
Browse files
Options

test262 roll 

Includes drive-by fix of a small BigInt bug, as caught by
test262/built-ins/BigInt/constructor-from-string-syntax-errors

Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng
Change-Id: Ic3b78310912f84bbf904a1fcb7ddf2d7eb2df013
Reviewed-on: https://chromium-review.googlesource.com/817775Reviewed-by: 's avatarSathya Gunasekaran (ooo until 12/12) <gsathya@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50010}
parent 8b1e0c64
Hide whitespace changes
Inline Side-by-side
Showing with 64 additions and 7 deletions
DEPS
View file @ 4a8d1e79
......@@ -47,7 +47,7 @@ deps = {
'v8/test/mozilla/data':
Var('chromium_url') + '/v8/deps/third_party/mozilla-tests.git' + '@' + 'f6c578a10ea707b1a8ab0b88943fe5115ce2b9be',
'v8/test/test262/data':
Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '5d4c667b271a9b39d0de73aef5ffe6879c6f8811',
Var('chromium_url') + '/external/github.com/tc39/test262.git' + '@' + '8311965251953d4745aeb68c98fb71fab2eac1d0',
'v8/test/test262/harness':
Var('chromium_url') + '/external/github.com/test262-utils/test262-harness-py.git' + '@' + '0f2acdd882c84cff43b9d60df7574a1901e2cdcd',
'v8/tools/clang':
......
src/conversions.cc
View file @ 4a8d1e79
......@@ -333,12 +333,12 @@ void StringToIntHelper::DetectRadixInternal(Char current, int length) {
(*current == 'o' || *current == 'O')) {
radix_ = 8;
++current;
DCHECK(current != end);
if (current == end) return set_state(kJunk);
} else if (allow_binary_and_octal_prefixes_ &&
(*current == 'b' || *current == 'B')) {
radix_ = 2;
++current;
DCHECK(current != end);
if (current == end) return set_state(kJunk);
} else {
leading_zero_ = true;
}
......
test/test262/test262.status
View file @ 4a8d1e79
......@@ -95,6 +95,8 @@
'built-ins/TypedArrays/internals/HasProperty/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/Set/detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/Set/detached-buffer-realm': [FAIL],
'built-ins/TypedArrays/internals/Set/tonumber-value-detached-buffer': [FAIL],
'built-ins/TypedArrays/internals/DefineOwnProperty/tonumber-value-detached-buffer': [FAIL],
# Some TypedArray methods throw due to the same bug, from Get
'built-ins/TypedArray/prototype/every/callbackfn-detachbuffer': [FAIL],
'built-ins/TypedArray/prototype/filter/callbackfn-detachbuffer': [FAIL],
......@@ -433,6 +435,59 @@
'language/statements/async-generator/yield-star-async-next': [FAIL],
'language/statements/class/async-gen-method-yield-star-async-next': [FAIL],
'language/statements/class/async-gen-method-static-yield-star-async-next': [FAIL],
'language/expressions/object/method-definition/async-gen-yield-star-sync-next': [FAIL],
'language/expressions/class/async-gen-method-static-yield-star-sync-next': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=6861
'language/expressions/async-generator/yield-star-sync-next': [FAIL],
'language/statements/class/async-gen-method-static-yield-star-sync-next': [FAIL],
'language/expressions/async-generator/named-yield-star-sync-next': [FAIL],
'language/expressions/class/async-gen-method-yield-star-sync-next': [FAIL],
'language/statements/class/async-gen-method-yield-star-sync-next': [FAIL],
'language/statements/async-generator/yield-star-sync-next': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=6791
'built-ins/BigInt/prototype/Symbol.toStringTag': [SKIP],
'built-ins/DataView/prototype/getBigInt64/*': [SKIP],
'built-ins/DataView/prototype/getBigUint64/*': [SKIP],
'built-ins/DataView/prototype/setBigInt64/*': [SKIP],
'built-ins/DataView/prototype/setBigUint64/*': [SKIP],
'built-ins/TypedArrays/BigInt64Array/*': [SKIP],
'built-ins/TypedArrays/BigUint64Array/*': [SKIP],
# https://bugs.chromium.org/p/v8/issues/detail?id=7183
'language/expressions/class/fields-arrow-fnc-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-comp-name-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-direct-eval-err-contains-arguments': [FAIL],
'language/expressions/class/fields-equality-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-literal-name-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-static-literal-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-static-string-literal-name-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-string-literal-name-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-ternary-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-typeof-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-arrow-fnc-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-direct-eval-err-contains-arguments': [FAIL],
'language/statements/class/fields-equality-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-literal-name-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-static-comp-name-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-static-literal-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-static-string-literal-name-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-string-literal-name-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-typeof-init-err-contains-arguments': [FAIL],
'language/expressions/class/fields-static-comp-name-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-ternary-init-err-contains-arguments': [FAIL],
'language/statements/class/fields-comp-name-init-err-contains-arguments': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7184
'annexB/language/expressions/yield/star-iterable-return-emulates-undefined-throws-when-called': [FAIL],
'annexB/language/statements/for-await-of/iterator-close-return-emulates-undefined-throws-when-called': [FAIL],
'annexB/language/statements/for-of/iterator-close-return-emulates-undefined-throws-when-called': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7186
'language/statements/class/fields-indirect-eval-err-contains-arguments': [FAIL],
'language/expressions/class/fields-indirect-eval-err-contains-arguments': [FAIL],
######################## NEEDS INVESTIGATION ###########################
......@@ -446,7 +501,6 @@
'intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle': [FAIL],
'intl402/DateTimeFormat/12.1.2': [PASS, FAIL],
'intl402/DateTimeFormat/12.2.3_b': [FAIL],
'intl402/Intl/getCanonicalLocales/success_cases': [FAIL],
'intl402/Number/prototype/toLocaleString/13.2.1_5': [PASS, FAIL],
'intl402/NumberFormat/11.1.1_20_c': [FAIL],
'intl402/NumberFormat/11.1.2': [PASS, FAIL],
......@@ -514,8 +568,10 @@
'harness/detachArrayBuffer': [SKIP],
'harness/detachArrayBuffer-host-detachArrayBuffer': [SKIP],
# Bogus test. Already fixed upstream.
'built-ins/BigInt/prototype/toString/length': [FAIL],
# https://github.com/tc39/test262/pull/1371
'language/expressions/bitwise-and/bigint-non-primitive': ['--harmony-bigint'],
'language/expressions/bitwise-or/bigint-non-primitive': ['--harmony-bigint'],
'language/expressions/bitwise-xor/bigint-non-primitive': ['--harmony-bigint'],
############################ SKIPPED TESTS #############################
......
test/test262/testcfg.py
View file @ 4a8d1e79
......@@ -46,9 +46,10 @@ FEATURE_FLAGS = {
'regexp-named-groups': '--harmony-regexp-named-captures',
'regexp-unicode-property-escapes': '--harmony-regexp-property',
'Promise.prototype.finally': '--harmony-promise-finally',
'class-fields-public': '--harmony-public-fields',
}
SKIPPED_FEATURES = set(['class-fields', 'optional-catch-binding'])
SKIPPED_FEATURES = set(['class-fields-private', 'optional-catch-binding'])
DATA = os.path.join(os.path.dirname(os.path.abspath(__file__)), "data")
ARCHIVE = DATA + ".tar"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment