Commit 48343621 authored by mbrandy's avatar mbrandy Committed by Commit bot

PPC: Fix '[strong] Disallow implicit conversions for comparison'

Do not trash type register in kIsNotStringMask test.

R=conradw@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1124333013

Cr-Commit-Position: refs/heads/master@{#28375}
parent 174242fb
......@@ -271,7 +271,7 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm, Label* slow,
// we need to throw a TypeError. Smis have already been ruled out.
__ cmpi(r7, Operand(HEAP_NUMBER_TYPE));
__ beq(&return_equal);
__ andi(r7, r7, Operand(kIsNotStringMask));
__ andi(r0, r7, Operand(kIsNotStringMask));
__ bne(slow, cr0);
}
} else {
......@@ -288,7 +288,7 @@ static void EmitIdenticalObjectComparison(MacroAssembler* masm, Label* slow,
// Call the runtime on anything that is converted in the semantics,
// since we need to throw a TypeError. Smis and heap numbers have
// already been ruled out.
__ andi(r7, r7, Operand(kIsNotStringMask));
__ andi(r0, r7, Operand(kIsNotStringMask));
__ bne(slow, cr0);
}
// Normally here we fall through to return_equal, but undefined is
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment