[turbofan] Teach the serializer about many more bytecodes

... all of the kind that modifies the accumulator but no other
registers. Also move a few of that kind out of the IGNORED_BYTECODES
list, where they didn't belong.

R=mslekova@chromium.org

Bug: v8:7790
Change-Id: I67189750e5e01fc8a3b6b5117b61a0d21837693a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561320
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60817}

src/compiler/serializer-for-background-compilation.h

@@ -35,11 +35,11 @@ namespace compiler {
   V(CallRuntime)                  \
   V(CallRuntimeForPair)           \
   V(CreateBlockContext)           \
-  V(CreateFunctionContext)        \
   V(CreateEvalContext)            \
+  V(CreateFunctionContext)        \
   V(Debugger)                     \
-  V(PushContext)                  \
   V(PopContext)                   \
+  V(PushContext)                  \
   V(ResumeGenerator)              \
   V(ReThrow)                      \
   V(StaContextSlot)               \
@@ -48,15 +48,75 @@ namespace compiler {
   V(SwitchOnGeneratorState)       \
   V(Throw)
 
-#define CLEAR_ACCUMULATOR_LIST(V) \
-  V(CreateEmptyObjectLiteral)     \
-  V(CreateMappedArguments)        \
-  V(CreateRestParameter)          \
-  V(CreateUnmappedArguments)      \
-  V(LdaContextSlot)               \
-  V(LdaCurrentContextSlot)        \
-  V(LdaImmutableContextSlot)      \
-  V(LdaImmutableCurrentContextSlot)
+#define CLEAR_ACCUMULATOR_LIST(V)   \
+  V(Add)                            \
+  V(AddSmi)                         \
+  V(BitwiseAnd)                     \
+  V(BitwiseAndSmi)                  \
+  V(BitwiseNot)                     \
+  V(BitwiseOr)                      \
+  V(BitwiseOrSmi)                   \
+  V(BitwiseXor)                     \
+  V(BitwiseXorSmi)                  \
+  V(CloneObject)                    \
+  V(CreateArrayFromIterable)        \
+  V(CreateArrayLiteral)             \
+  V(CreateEmptyArrayLiteral)        \
+  V(CreateEmptyObjectLiteral)       \
+  V(CreateMappedArguments)          \
+  V(CreateObjectLiteral)            \
+  V(CreateRestParameter)            \
+  V(CreateUnmappedArguments)        \
+  V(Dec)                            \
+  V(DeletePropertySloppy)           \
+  V(DeletePropertyStrict)           \
+  V(Div)                            \
+  V(DivSmi)                         \
+  V(Exp)                            \
+  V(ExpSmi)                         \
+  V(ForInContinue)                  \
+  V(ForInEnumerate)                 \
+  V(ForInNext)                      \
+  V(ForInStep)                      \
+  V(GetTemplateObject)              \
+  V(Inc)                            \
+  V(LdaContextSlot)                 \
+  V(LdaCurrentContextSlot)          \
+  V(LdaImmutableContextSlot)        \
+  V(LdaImmutableCurrentContextSlot) \
+  V(LogicalNot)                     \
+  V(Mod)                            \
+  V(ModSmi)                         \
+  V(Mul)                            \
+  V(MulSmi)                         \
+  V(Negate)                         \
+  V(SetPendingMessage)              \
+  V(ShiftLeft)                      \
+  V(ShiftLeftSmi)                   \
+  V(ShiftRight)                     \
+  V(ShiftRightLogical)              \
+  V(ShiftRightLogicalSmi)           \
+  V(ShiftRightSmi)                  \
+  V(Sub)                            \
+  V(SubSmi)                         \
+  V(TestEqual)                      \
+  V(TestEqualStrict)                \
+  V(TestGreaterThan)                \
+  V(TestGreaterThanOrEqual)         \
+  V(TestInstanceOf)                 \
+  V(TestLessThan)                   \
+  V(TestLessThanOrEqual)            \
+  V(TestNull)                       \
+  V(TestReferenceEqual)             \
+  V(TestTypeOf)                     \
+  V(TestUndefined)                  \
+  V(TestUndetectable)               \
+  V(ToBooleanLogicalNot)            \
+  V(ToName)                         \
+  V(ToNumber)                       \
+  V(ToNumeric)                      \
+  V(ToString)                       \
+  V(TypeOf)
 
 #define UNCONDITIONAL_JUMPS_LIST(V) \
   V(Jump)                           \
@@ -74,10 +134,10 @@ namespace compiler {
   V(JumpIfNotUndefinedConstant)   \
   V(JumpIfNull)                   \
   V(JumpIfNullConstant)           \
-  V(JumpIfToBooleanTrueConstant)  \
+  V(JumpIfToBooleanFalse)         \
   V(JumpIfToBooleanFalseConstant) \
   V(JumpIfToBooleanTrue)          \
-  V(JumpIfToBooleanFalse)         \
+  V(JumpIfToBooleanTrueConstant)  \
   V(JumpIfTrue)                   \
   V(JumpIfTrueConstant)           \
   V(JumpIfUndefined)              \
@@ -88,18 +148,6 @@ namespace compiler {
   V(LdaNamedPropertyNoFeedback)       \
   V(StackCheck)                       \
   V(StaNamedPropertyNoFeedback)       \
-  V(TestEqual)                        \
-  V(TestEqualStrict)                  \
-  V(TestGreaterThan)                  \
-  V(TestGreaterThanOrEqual)           \
-  V(TestInstanceOf)                   \
-  V(TestLessThan)                     \
-  V(TestLessThanOrEqual)              \
-  V(TestNull)                         \
-  V(TestReferenceEqual)               \
-  V(TestTypeOf)                       \
-  V(TestUndefined)                    \
-  V(TestUndetectable)                 \
   V(ThrowReferenceErrorIfHole)        \
   V(ThrowSuperAlreadyCalledIfNotHole) \
   V(ThrowSuperNotCalledIfHole)
@@ -121,8 +169,8 @@ namespace compiler {
   V(ExtraWide)                       \
   V(GetSuperConstructor)             \
   V(Illegal)                         \
-  V(LdaFalse)                        \
   V(LdaConstant)                     \
+  V(LdaFalse)                        \
   V(LdaGlobal)                       \
   V(LdaGlobalInsideTypeof)           \
   V(LdaKeyedProperty)                \

test/mjsunit/compiler/typedarray-keyed.js

@@ -25,8 +25,7 @@ assertEquals(0, get(0));
 assertEquals(0, get(1));
 
 function set(i) {
-  const x = 42 + i;
-  return a[i] = x;
+  return a[i] = 42 + i;
 }
 assertEquals(42, set(0)); assertEquals(42, a[0]);
 assertEquals(42, set(0)); assertEquals(42, a[0]);