Commit 45847bd1 authored by iposva@chromium.org's avatar iposva@chromium.org

- Rename flags.defs to flag-definitions.h.

- Add better support for ignoring files in the presubmit tool.

Review URL: http://codereview.chromium.org/3082

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@322 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 1409dc5d
...@@ -36,11 +36,11 @@ namespace v8 { namespace internal { ...@@ -36,11 +36,11 @@ namespace v8 { namespace internal {
// Define all of our flags. // Define all of our flags.
#define FLAG_MODE_DEFINE #define FLAG_MODE_DEFINE
#include "flags.defs" #include "flag-definitions.h"
// Define all of our flags default values. // Define all of our flags default values.
#define FLAG_MODE_DEFINE_DEFAULTS #define FLAG_MODE_DEFINE_DEFAULTS
#include "flags.defs" #include "flag-definitions.h"
namespace { namespace {
...@@ -143,7 +143,7 @@ struct Flag { ...@@ -143,7 +143,7 @@ struct Flag {
Flag flags[] = { Flag flags[] = {
#define FLAG_MODE_META #define FLAG_MODE_META
#include "flags.defs" #include "flag-definitions.h"
}; };
const size_t num_flags = sizeof(flags) / sizeof(*flags); const size_t num_flags = sizeof(flags) / sizeof(*flags);
......
...@@ -33,7 +33,7 @@ namespace v8 { namespace internal { ...@@ -33,7 +33,7 @@ namespace v8 { namespace internal {
// Declare all of our flags. // Declare all of our flags.
#define FLAG_MODE_DECLARE #define FLAG_MODE_DECLARE
#include "flags.defs" #include "flag-definitions.h"
// The global list of all flags. // The global list of all flags.
class FlagList { class FlagList {
......
...@@ -134,6 +134,12 @@ class CppLintProcessor(SourceFileProcessor): ...@@ -134,6 +134,12 @@ class CppLintProcessor(SourceFileProcessor):
return (super(CppLintProcessor, self).IgnoreDir(name) return (super(CppLintProcessor, self).IgnoreDir(name)
or (name == 'third_party')) or (name == 'third_party'))
IGNORE_LINT = ['flag-definitions.h']
def IgnoreFile(self, name):
return (super(CppLintProcessor, self).IgnoreFile(name)
or (name in CppLintProcessor.IGNORE_LINT))
def GetPathsToSearch(self): def GetPathsToSearch(self):
return ['src', 'public', 'samples', join('test', 'cctest')] return ['src', 'public', 'samples', join('test', 'cctest')]
...@@ -168,7 +174,8 @@ class SourceProcessor(SourceFileProcessor): ...@@ -168,7 +174,8 @@ class SourceProcessor(SourceFileProcessor):
or (name == 'third_party') or (name == 'third_party')
or (name == 'obj')) or (name == 'obj'))
IGNORE_COPYRIGHTS = ['earley-boyer.js', 'raytrace.js', 'crypto.js'] IGNORE_COPYRIGHTS = ['earley-boyer.js', 'raytrace.js', 'crypto.js',
'libraries.cc', 'libraries-empty.cc']
IGNORE_TABS = IGNORE_COPYRIGHTS + ['unicode-test.js', IGNORE_TABS = IGNORE_COPYRIGHTS + ['unicode-test.js',
'html-comments.js'] 'html-comments.js']
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment