Commit 457a86fb authored by Leszek Swirski's avatar Leszek Swirski Committed by Commit Bot

[sparkplug] Re-fix frame fill on arm64

We had an off-by-one in the arm64 frame fill code due to double counting
the register already pushed by the prologue.

Bug: v8:11420
Change-Id: I9b4a3bcdc913886f0ba7a316f23f41eed3fc9311
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2707168
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72872}
parent 63946bd5
...@@ -524,7 +524,9 @@ void BaselineCompiler::PrologueFillFrame() { ...@@ -524,7 +524,9 @@ void BaselineCompiler::PrologueFillFrame() {
__ masm()->Push(kInterpreterAccumulatorRegister, __ masm()->Push(kInterpreterAccumulatorRegister,
kJavaScriptCallNewTargetRegister); kJavaScriptCallNewTargetRegister);
} }
register_count -= (index + 2); // We pushed "index" registers, minus the one the prologue pushed, plus
// the two registers that included new_target.
register_count -= (index - 1 + 2);
} }
} }
if (register_count < 2 * kLoopUnrollSize) { if (register_count < 2 * kLoopUnrollSize) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment