Commit 44da77fc authored by Peter Marshall's avatar Peter Marshall Committed by Commit Bot

[cpu-profiler] Disable DCHECK for arm simulator

The simulator builds have bugs which cause invalid frame markers in
some cases.

Change-Id: I837732c6f5efe24821415a0ae0626578bbcc3a7e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1697253Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
Commit-Queue: Peter Marshall <petermarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62650}
parent b048429e
......@@ -148,9 +148,9 @@ class StackFrame {
static Type MarkerToType(intptr_t marker) {
DCHECK(IsTypeMarker(marker));
intptr_t type = marker >> kSmiTagSize;
// TODO(petermarshall): There is a bug in the arm64 simulator that causes
// TODO(petermarshall): There is a bug in the arm simulators that causes
// invalid frame markers.
#if !(defined(USE_SIMULATOR) && V8_TARGET_ARCH_ARM64)
#if !(defined(USE_SIMULATOR) && (V8_TARGET_ARCH_ARM64 || V8_TARGET_ARCH_ARM))
DCHECK_LT(static_cast<uintptr_t>(type), Type::NUMBER_OF_TYPES);
#endif
return static_cast<Type>(type);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment