Commit 44086602 authored by Ross McIlroy's avatar Ross McIlroy Committed by Commit Bot

[CSA][Cleanup] TNodify EmitElementStore and CheckForCapacityGrow.

One remaining Node* remains in EmitElementStore which will need to wait for
templated versions of StoreElement.

BUG=v8:10021

Change-Id: I6422b8dbfd1989cfc7587c2b180e542fbdb56382
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007271Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65851}
parent c3e5352a
...@@ -77,7 +77,7 @@ TNode<Object> ArrayBuiltinsAssembler::TypedArrayMapProcessor( ...@@ -77,7 +77,7 @@ TNode<Object> ArrayBuiltinsAssembler::TypedArrayMapProcessor(
// TODO(v8:4153): Consider checking IsDetachedBuffer() and calling // TODO(v8:4153): Consider checking IsDetachedBuffer() and calling
// TypedArrayBuiltinsAssembler::StoreJSTypedArrayElementFromNumeric() here // TypedArrayBuiltinsAssembler::StoreJSTypedArrayElementFromNumeric() here
// instead to avoid converting k_number back to UintPtrT. // instead to avoid converting k_number back to UintPtrT.
EmitElementStore(a(), k_number, num_value, source_elements_kind_, EmitElementStore(CAST(a()), k_number, num_value, source_elements_kind_,
KeyedAccessStoreMode::STANDARD_STORE, &detached, context()); KeyedAccessStoreMode::STANDARD_STORE, &detached, context());
Goto(&done); Goto(&done);
......
This diff is collapsed.
...@@ -3336,15 +3336,16 @@ class V8_EXPORT_PRIVATE CodeStubAssembler ...@@ -3336,15 +3336,16 @@ class V8_EXPORT_PRIVATE CodeStubAssembler
void BigIntToRawBytes(TNode<BigInt> bigint, TVariable<UintPtrT>* var_low, void BigIntToRawBytes(TNode<BigInt> bigint, TVariable<UintPtrT>* var_low,
TVariable<UintPtrT>* var_high); TVariable<UintPtrT>* var_high);
void EmitElementStore(Node* object, Node* key, Node* value, void EmitElementStore(TNode<JSObject> object, TNode<Object> key,
ElementsKind elements_kind, TNode<Object> value, ElementsKind elements_kind,
KeyedAccessStoreMode store_mode, Label* bailout, KeyedAccessStoreMode store_mode, Label* bailout,
Node* context, TNode<Context> context,
Variable* maybe_converted_value = nullptr); TVariable<Object>* maybe_converted_value = nullptr);
Node* CheckForCapacityGrow(Node* object, Node* elements, ElementsKind kind, Node* CheckForCapacityGrow(TNode<JSObject> object,
SloppyTNode<UintPtrT> length, TNode<IntPtrT> key, TNode<FixedArrayBase> elements, ElementsKind kind,
ParameterMode mode, Label* bailout); TNode<UintPtrT> length, TNode<IntPtrT> key,
Label* bailout);
Node* CopyElementsOnWrite(Node* object, Node* elements, ElementsKind kind, Node* CopyElementsOnWrite(Node* object, Node* elements, ElementsKind kind,
Node* length, ParameterMode mode, Label* bailout); Node* length, ParameterMode mode, Label* bailout);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment